build: Fix compilation failure with Rust v1.80

Starting with version 1.80, the Rust linter does not accept an invalid
value for `target_arch` in configuration checks:

```
   Compiling kata-sys-util v0.1.0 (/home/ddd/Work/kata/kata-containers/src/libs/kata-sys-util)
error: unexpected `cfg` condition value: `powerpc64le`

  --> /home/ddd/Work/kata/kata-containers/src/libs/kata-sys-util/src/protection.rs:17:34
   |
17 | #[cfg(any(target_arch = "s390x", target_arch = "powerpc64le"))]
   |                                  ^^^^^^^^^^^^^^-------------
   |                                                |
   |                                                help: there is a expected value with a similar name: `"powerpc64"`
   |
   = note: expected values for `target_arch` are: `aarch64`, `arm`, `arm64ec`, `avr`, `bpf`, `csky`, `hexagon`, `loongarch64`, `m68k`, `mips`, `mips32r6`, `mips64`, `mips64r6`, `msp430`, `nvptx64`, `powerpc`, `powerpc64`, `riscv32`, `riscv64`, `s390x`, `sparc`, `sparc64`, `wasm32`, `wasm64`, `x86`, and `x86_64`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
   = note: `-D unexpected-cfgs` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]`
```

According [to GitHub user @Urgau][explain], this is a new warning
introduced in Rust 1.80, but the problem exists before. The correct
architecture name should be `powerpc64`, and the differentiation
between `powerpc64le` and `powerpc64` should use the `target_endian =
"little"` check.

[explain]: kata-containers#10072 (comment)

Fixes: kata-containers#10067

Signed-off-by: Christophe de Dinechin <[email protected]>
[emlima: fix some more occurences and typos]
Signed-off-by: Emanuel Lima <[email protected]>

Author: Emanuel Lima

docs/Developer-Guide.md

@@ -239,7 +239,7 @@ The agent is built with a statically linked `musl.` The default `libc` used is `
 ```bash
 $ export ARCH="$(uname -m)"
 $ if [ "$ARCH" = "ppc64le" -o "$ARCH" = "s390x" ]; then export LIBC=gnu; else export LIBC=musl; fi
-$ [ "${ARCH}" == "ppc64le" ] && export ARCH=powerpc64le
+$ [ "${ARCH}" == "ppc64le" ] && export ARCH=powerpc64
 $ rustup target add "${ARCH}-unknown-linux-${LIBC}"
 ```
 
@@ -415,11 +415,11 @@ $ script -fec 'sudo -E AGENT_INIT=yes USE_DOCKER=true SECCOMP=no ./rootfs.sh "${
 > - Check the [compatibility matrix](../tools/osbuilder/README.md#platform-distro-compatibility-matrix) before creating rootfs.
 
 Optionally, add your custom agent binary to the rootfs with the following commands. The default `$LIBC` used
-is `musl`, but on ppc64le and s390x, `gnu` should be used. Also, Rust refers to ppc64le as `powerpc64le`:
+is `musl`, but on ppc64le and s390x, `gnu` should be used. Also, Rust refers to ppc64le as `powerpc64`:
 ```bash
 $ export ARCH="$(uname -m)"
 $ [ "${ARCH}" == "ppc64le" ] || [ "${ARCH}" == "s390x" ] && export LIBC=gnu || export LIBC=musl
-$ [ "${ARCH}" == "ppc64le" ] && export ARCH=powerpc64le
+$ [ "${ARCH}" == "ppc64le" ] && export ARCH=powerpc64
 $ sudo install -o root -g root -m 0550 -T "${ROOTFS_DIR}/../../../../src/agent/target/${ARCH}-unknown-linux-${LIBC}/release/kata-agent" "${ROOTFS_DIR}/sbin/init"
 ```
 

src/agent/Makefile

@@ -54,7 +54,7 @@ endif
 include ../../utils.mk
 
 ifeq ($(ARCH), ppc64le)
-    override ARCH = powerpc64le
+    override ARCH = powerpc64
 endif
 
 ##VAR STANDARD_OCI_RUNTIME=yes|no define if agent enables standard oci runtime feature

src/libs/kata-sys-util/src/protection.rs

@@ -14,7 +14,7 @@ use std::path::Path;
 use std::path::PathBuf;
 use thiserror::Error;
 
-#[cfg(any(target_arch = "s390x", target_arch = "powerpc64le"))]
+#[cfg(any(target_arch = "s390x", target_arch = "powerpc64"))]
 use nix::unistd::Uid;
 
 #[cfg(target_arch = "x86_64")]
@@ -234,7 +234,7 @@ pub fn available_guest_protection() -> Result<GuestProtection, ProtectionError>
     Ok(GuestProtection::Se)
 }
 
-#[cfg(target_arch = "powerpc64le")]
+#[cfg(all(target_arch = "powerpc64"))]
 pub fn available_guest_protection() -> Result<check::GuestProtection, check::ProtectionError> {
     if !Uid::effective().is_root() {
         return Err(check::ProtectionError::NoPerms);

src/runtime-rs/Makefile

@@ -18,7 +18,7 @@ CONTAINERD_RUNTIME_NAME = io.containerd.kata.v2
 include ../../utils.mk
 
 ifeq ($(ARCH), ppc64le)
-    override ARCH = powerpc64le
+    override ARCH = powerpc64
 endif
 
 ARCH_DIR = arch
@@ -31,7 +31,7 @@ test:
 	@echo "s390x is not currently supported"
 	exit 0
 install: install-runtime install-configs
-else ifeq ($(ARCH), powerpc64le)
+else ifeq ($(ARCH), powerpc64)
 default:
 	@echo "PowerPC 64 LE is not currently supported"
 	exit 0

src/tools/agent-ctl/Makefile

@@ -6,7 +6,7 @@
 include ../../../utils.mk
 
 ifeq ($(ARCH), ppc64le)
-     override ARCH = powerpc64le
+     override ARCH = powerpc64
 endif
 
 .DEFAULT_GOAL := default

src/tools/genpolicy/Makefile

@@ -7,7 +7,7 @@
 include ../../../utils.mk
 
 ifeq ($(ARCH), ppc64le)
-     override ARCH = powerpc64le
+     override ARCH = powerpc64
  endif
 
 COMMIT_HASH := $(shell git rev-parse HEAD 2>/dev/null || true)

src/tools/kata-ctl/Cross.toml

@@ -8,5 +8,5 @@ pre-build = ["dpkg --add-architecture arm64 && apt-get update && apt-get install
 pre-build = ["dpkg --add-architecture amd64 && apt-get update && apt-get install -y libssl-dev:amd64"]
 
 # Powerpc compile seems to be broken, due to `ring` crate not being supported on powerpc.
-[target.powerpc64le-unknown-linux-gnu]
+[target.powerpc64-unknown-linux-gnu]
 pre-build = ["dpkg --add-architecture ppc64le && apt-get update && apt-get install -y libssl-dev:ppc64le"]

src/tools/kata-ctl/src/arch/mod.rs

@@ -8,10 +8,10 @@ pub mod aarch64;
 #[cfg(target_arch = "aarch64")]
 pub use aarch64 as arch_specific;
 
-#[cfg(target_arch = "powerpc64le")]
-pub mod powerpc64le;
-#[cfg(target_arch = "powerpc64le")]
-pub use powerpc64le as arch_specific;
+#[cfg(all(target_arch = "powerpc64"))]
+pub mod powerpc64;
+#[cfg(all(target_arch = "powerpc64"))]
+pub use powerpc64 as arch_specific;
 
 #[cfg(target_arch = "s390x")]
 pub mod s390x;
@@ -25,7 +25,7 @@ pub use x86_64 as arch_specific;
 
 #[cfg(not(any(
     target_arch = "aarch64",
-    target_arch = "powerpc64le",
+    target_arch = "powerpc64",
     target_arch = "s390x",
     target_arch = "x86_64"
 )))]

src/tools/kata-ctl/src/arch/powerpc64le/mod.rs renamed to src/tools/kata-ctl/src/arch/powerpc64/mod.rs

@@ -4,7 +4,7 @@
 //
 
 use crate::types::*;
-#[cfg(target_arch = "powerpc64le")]
+#[cfg(all(target_arch = "powerpc64"))]
 pub use arch_specific::*;
 
 mod arch_specific {
@@ -16,7 +16,7 @@ mod arch_specific {
     pub const ARCH_CPU_MODEL_FIELD: &str = "model";
 
     pub fn check() -> Result<()> {
-        unimplemented!("Check not implemented in powerpc64le");
+        unimplemented!("Check not implemented in powerpc64");
     }
 
     pub fn get_checks() -> Option<&'static [CheckItem<'static>]> {

src/tools/runk/Makefile

@@ -9,7 +9,7 @@ LIBC ?= gnu
 include ../../../utils.mk
 
 ifeq ($(ARCH), ppc64le)
-     override ARCH = powerpc64le
+     override ARCH = powerpc64
 endif
 
 TARGET = runk