Skip to content

OpenAMP list.h name collision with freertos list.h #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gigaj0ule opened this issue Nov 7, 2019 · 6 comments
Closed

OpenAMP list.h name collision with freertos list.h #760

gigaj0ule opened this issue Nov 7, 2019 · 6 comments
Labels
invalid This doesn't seem right

Comments

@gigaj0ule
Copy link
Contributor

gigaj0ule commented Nov 7, 2019

When compiling with stm32freertos, list.h in OpenAMP's name over-rides list.h with freertos and compilation fails. Renaming OpenAMP's list.h solves this issue.

@fpistm
Copy link
Member

fpistm commented Nov 7, 2019

Hi @adammunich
Thanks for reporting this.
Currenlty, I guess I will remove OpenAMP from include list in the platform.txt as it is not used.
/CC @kbumsik

@fpistm
Copy link
Member

fpistm commented Nov 7, 2019

@adammunich
How you met the issue?
I have no issue. I thought OpenAmp include path was in the platform.txt but this is not.

@fpistm fpistm added the waiting feedback Further information is required label Nov 7, 2019
@gigaj0ule
Copy link
Contributor Author

gigaj0ule commented Nov 7, 2019

Some platforms and makefiles I have seen include Arduino_Core_STM32/system/Middlewares/ recursively, which causes the issue.

@kbumsik
Copy link
Contributor

kbumsik commented Nov 7, 2019

@fpistm The virtual serial using OpenAMP is completed and it's in code cleaning phase. I'm going to make a PR right after #717 is merged. I will rename it or will consider this case when I'm proposing the PR.

@adammunich Could I ask what platforms are? I'm personally interested in projects using stm32freertos.

Arduino_Core_STM32/system/Middlewares/ recursively

This sounds like their responsibility to update the project build configurations though.

@fpistm
Copy link
Member

fpistm commented Nov 8, 2019

Some platforms and makefiles I have seen include Arduino_Core_STM32/system/Middlewares/ recursively, which causes the issue.

I do not known where you see it but currently this is not included anywhere.
So, I guess you use an other environment with some customization and from my point of view this issue is not valid at this time. Anyway, this should be manage when OpenAMP will be in the path.
FreeRTOS and OpenAMP should be exclusive

@fpistm
Copy link
Member

fpistm commented Nov 15, 2019

This sounds like their responsibility to update the project build configurations though.

I agree with @kbumsik.
I see no issue with list.h as OpenAmp requires to include it thanks: #include <metal/list.h>

@fpistm fpistm closed this as completed Nov 15, 2019
@fpistm fpistm added invalid This doesn't seem right and removed waiting feedback Further information is required labels Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants