syntax highlighting in action logger#118
Merged
arunoda merged 4 commits intostorybookjs:masterfrom Apr 19, 2016
ritz078:feat/syntax-highlighting
Merged
syntax highlighting in action logger#118arunoda merged 4 commits intostorybookjs:masterfrom ritz078:feat/syntax-highlighting
arunoda merged 4 commits intostorybookjs:masterfrom
ritz078:feat/syntax-highlighting
Conversation
Contributor
ritz078
commented
Apr 18, 2016
ritz078
commented
| }; | ||
|
|
||
| const fullString = '{\n "name": "test action",\n "args": "things"\n}'; | ||
| const fullString = '{\n name: "test action",\n args: "things"\n}'; |
Member
There was a problem hiding this comment.
Can't we write an additional test case targetted for syntax highlighting.
Member
|
Overall, this looks cool. |
Contributor
Author
|
@arunoda added tests and comment |
Member
|
Okay. Great. |
Member
|
Published as |
wyattdanger
pushed a commit
to wyattdanger/react-storybook
that referenced
this pull request
Apr 26, 2016
* feat(highlight):added syntax highlighting in the action logger * fix lint error * fixed tests * added tests for highlight
|
View your CI Pipeline Execution ↗ for commit 3e2d64f
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.