Fix for #183 - issue with removing a preset from users babelrc#184
Merged
arunoda merged 1 commit intostorybookjs:masterfrom May 10, 2016
Merged
Fix for #183 - issue with removing a preset from users babelrc#184arunoda merged 1 commit intostorybookjs:masterfrom
arunoda merged 1 commit intostorybookjs:masterfrom
Conversation
This was referenced Dec 25, 2022
|
View your CI Pipeline Execution ↗ for commit 3fd60c4
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is our babelrc
indexOf('react-hmre') was returning -1 as we don't have it in our presets and presets.splice(-1,1) was removing the last preset from our configuration.
I ran npm run test and linter and tests all passed.
Thanks