Skip to content

Export storybook middleware#211

Merged
thani-sh merged 1 commit intomasterfrom
storybook-mw
May 25, 2016
Merged

Export storybook middleware#211
thani-sh merged 1 commit intomasterfrom
storybook-mw

Conversation

@thani-sh
Copy link
Copy Markdown
Contributor

@thani-sh thani-sh commented May 24, 2016

It'll be much easier to integrate storybook into existing systems for users if storybook is available as an express middleware. This issue is an example use case.

@thani-sh thani-sh force-pushed the storybook-mw branch 2 times, most recently from 4cb20a9 to 54422a9 Compare May 24, 2016 13:31
@arunoda
Copy link
Copy Markdown
Member

arunoda commented May 25, 2016

Since this is just the our same logic. I think we can proceed with this.

And also, building storybook also works fine.
I am good with this. Merge and make a release.

@thani-sh thani-sh merged commit 52a019a into master May 25, 2016
@thani-sh thani-sh deleted the storybook-mw branch May 25, 2016 07:39
@ericclemmons
Copy link
Copy Markdown
Contributor

I'm not sure best to import this. require("@kadira/storybook/dist/server/middleware").default seems kinda brittle, no?

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Nov 16, 2024

View your CI Pipeline Execution ↗ for commit 630af70.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-31 03:11:53 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants