Make bundle location relative to webpack publicPath#226
Merged
thani-sh merged 1 commit intostorybookjs:masterfrom Jun 6, 2016
Merged
Make bundle location relative to webpack publicPath#226thani-sh merged 1 commit intostorybookjs:masterfrom
thani-sh merged 1 commit intostorybookjs:masterfrom
Conversation
Contributor
|
Thank you @bmagnus edit: |
Contributor
|
Released |
|
View your CI Pipeline Execution ↗ for commit 84e3e23.
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The paths for manager.bundle.js and preview.bundle.js are currently hard-coded to match the webpack publicPath that is set in this project (
/static/). If I override the publicPath in a custom webpack config, Storybook will not find the bundles because it will still look for/static/{bundle}.This pull request makes the bundle paths (in the html produced by index.html.js and iframe.html.js) relative to the publicPath variable.