Conversation
arunoda
reviewed
Sep 22, 2016
| // check whether we're running on node/browser | ||
| const isBrowser = typeof window !== 'undefined'; | ||
| // storyshots got polyfills for window so need to make sure its not storyshots | ||
| const isBrowser = typeof window !== 'undefined' && !isStoryShots; |
Member
There was a problem hiding this comment.
How about this:
const { navigator } = global;
const isBrowser = navigator && navigator. userAgent !== 'storyshots';
roonyh
force-pushed
the
check-if-storyshots
branch
from
fba3a84 to
bb7cb66
Compare
storyshots adds polyfills for window. So preview will incorrectly assume we’re on a browser. This will avoid that.
roonyh
force-pushed
the
check-if-storyshots
branch
from
bb7cb66 to
6309b54
Compare
arunoda
changed the title
ghost
mentioned this pull request
|
View your CI Pipeline Execution ↗ for commit 6309b54
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storyshots adds polyfills for window. So preview will incorrectly assume we’re on a browser. This will avoid that.