Skip to content

display storybook version#559

Merged
arunoda merged 2 commits intostorybookjs:masterfrom
usulpro:master
Oct 27, 2016
Merged

display storybook version#559
arunoda merged 2 commits intostorybookjs:masterfrom
usulpro:master

Conversation

@usulpro
Copy link
Copy Markdown
Member

@usulpro usulpro commented Oct 23, 2016

here it is #553

arunoda
arunoda reviewed Oct 24, 2016
View reviewed changes
Comment thread src/server/index.js Outdated
.option('--enable-db', 'DEPRECATED!')
.parse(process.argv);

logger.info(chalk.bold(`${packageJson.name} v${packageJson.version}`));
Copy link
Copy Markdown
Member

@arunoda arunoda Oct 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line to end of this line.

arunoda
arunoda suggested changes Oct 24, 2016
View reviewed changes
Copy link
Copy Markdown
Member

@arunoda arunoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to the build.js in the same directory.
That's what's get invoked when you run npm run build-storybook.

@usulpro
Copy link
Copy Markdown
Member Author

usulpro commented Oct 25, 2016

Ok

@arunoda arunoda merged commit bc9e6ac into storybookjs:master Oct 27, 2016
@usulpro
Copy link
Copy Markdown
Member Author

usulpro commented Oct 27, 2016

Hi @arunoda
Is everything Ok with it? Just let me know if I need to fix something
I checked it under Windows:

start-storybook build-storybook
image image

It may be worth adding "start" and "build" between the name and version?

@arunoda
Copy link
Copy Markdown
Member

arunoda commented Oct 27, 2016

I just published a new version with the PR you sent.

I didn't get this part?

It may be worth adding "start" and "build" between the name and version?

@usulpro
Copy link
Copy Markdown
Member Author

usulpro commented Oct 27, 2016

I just wrote this in the same moment when you merged it and didn't see it :)
I think in general it should be clear what the command is executed. So it's not necessary

@shilman shilman added the misc label May 27, 2017
This was referenced Jun 20, 2023
Closed
Closed
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Sep 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bc9e6ac

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 51s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-01 09:31:18 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arunoda arunoda arunoda requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@usulpro @arunoda @shilman