Check if regex and regex.test is available before calling it#608
Merged
arunoda merged 3 commits intostorybookjs:masterfrom Nov 9, 2016
kitze:master
Merged
Check if regex and regex.test is available before calling it#608arunoda merged 3 commits intostorybookjs:masterfrom kitze:master
arunoda merged 3 commits intostorybookjs:masterfrom
kitze:master
Conversation
Member
Contributor
Author
|
@arunoda just replied. |
arunoda
suggested changes
Nov 8, 2016
Member
arunoda
left a comment
arunoda
left a comment
There was a problem hiding this comment.
After that, we are good to go.
| const jsonLoaderExists = config.module.loaders.reduce( | ||
| (value, loader) => { | ||
| return value || [].concat(loader.test).some(regex => regex && regex.test && regex.test('my_package.json')); | ||
| return value || [].concat(loader.test).some((loader) => { |
Member
There was a problem hiding this comment.
Could you rename this loader name into something like matcher.
Like this:
return value || [].concat(loader.test).some((matcher) => { ...
arunoda
approved these changes
Nov 9, 2016
Member
|
Awesome. |
|
View your CI Pipeline Execution ↗ for commit a86a5f3.
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #607