Change brand name from “React Storybook” to “Storybook”#1044
Merged
Change brand name from “React Storybook” to “Storybook”#1044
Conversation
shilman
requested changes
May 17, 2017
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
Minor change unrelated to your change, but on the same line.
|
|
||
| ```sh | ||
| npm install -save-dev storyshots | ||
| npm install -save-dev @storybook/addon-storyshots |
Member
Author
There was a problem hiding this comment.
Nice catch, can you approve now?
Member
|
So we officialy rename seems logical 👍 |
Member
Author
|
It's still the top hit? I see no problem with this. It's a needed step. |
ndelangen
changed the title
ghost
mentioned this pull request
|
View your CI Pipeline Execution ↗ for commit d2cdb0a
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did