Add support for multiple webpack chunks in iframe#1083
Merged
Conversation
This allows an arbitrary number of files to be loaded into the iframe, not just the single `preview.bundle.js` file. Webpack plugins can output chunks in a separate file. In dev, since file names are predictable, I can add the js file into a head.html file. When building storybook statically, however, js files have a hash added to them, so this doesn't work. This change makes the static build parse all webpack chunks and load them in the iframe (excluding the manager script), instead of only including known files.
Member
Author
|
@apexskier Can you please review and test? |
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
=========================================
Coverage ? 13.64%
=========================================
Files ? 207
Lines ? 4640
Branches ? 517
=========================================
Hits ? 633
Misses ? 3555
Partials ? 452
Continue to review full report at Codecov.
|
Member
Author
Can someone please review? |
danielduan
approved these changes
Jun 7, 2017
This was referenced Feb 1, 2022
This was referenced Aug 12, 2023
This was referenced Nov 25, 2023
|
View your CI Pipeline Execution ↗ for commit 207eb44
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement PR for #677
This allows an arbitrary number of files to be loaded into the iframe,
not just the single
preview.bundle.jsfile.Webpack plugins can output chunks in a separate file. In dev, since
file names are predictable, I can add the js file into a head.html file.
When building storybook statically, however, js files have a hash added
to them, so this doesn't work.
This change makes the static build parse all webpack chunks and load
them in the iframe (excluding the manager script), instead of only
including known files.