Show webpack 2 config example in docs: rules not loaders#1137
Merged
ndelangen merged 1 commit intostorybookjs:masterfrom May 27, 2017
Stupidism:fix-custom-webpack-config
Merged
Show webpack 2 config example in docs: rules not loaders#1137ndelangen merged 1 commit intostorybookjs:masterfrom Stupidism:fix-custom-webpack-config
ndelangen merged 1 commit intostorybookjs:masterfrom
Stupidism:fix-custom-webpack-config
Conversation
Member
|
Thanks! @ndelangen this needs to go in #1093 migration guide for sure! |
Codecov Report
@@ Coverage Diff @@
## master #1137 +/- ##
=======================================
Coverage 12.86% 12.86%
=======================================
Files 198 198
Lines 4501 4501
Branches 715 715
=======================================
Hits 579 579
Misses 3289 3289
Partials 633 633Continue to review full report at Codecov.
|
Member
|
@Stupidism sorry for the trouble. We are hustling to document the changes for 3.0 before the release, so things are a little inconsistent for the next couple days. Thanks so much for your contribution! 👍 |
ndelangen
approved these changes
May 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
It took me 2 hours to figure it out how to config webpack in the new version.
All I wanted is something like this. But I'm not familiar with webpack breaking changes.
What I did
changed
module.loadersintomodule.rulesin docs/**/custome-webpack-config.mdHow to test