Use strict equality in action logger#1144
Merged
shilman merged 1 commit intostorybookjs:masterfrom May 28, 2017
Merged
Conversation
shilman
approved these changes
May 28, 2017
Member
shilman
left a comment
There was a problem hiding this comment.
Great catch! Thanks for the fix and your contribution to Storybook!!!
Codecov Report
@@ Coverage Diff @@
## master #1144 +/- ##
=======================================
Coverage 12.75% 12.75%
=======================================
Files 199 199
Lines 4571 4571
Branches 724 724
=======================================
Hits 583 583
Misses 3347 3347
Partials 641 641
Continue to review full report at Codecov.
|
Contributor
Author
No problem. Happy to contribute to such great piece of software! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When comparing
0and empty string (''), action logger doesn't see the difference. See storybook-eol/storybook-addon-actions#33.Steps to reproduce the issue:
0[0]is logged in''[0]is logged inWhat I did
Added strict equality to distinguish
0from an empty string ('').How to test
Use action logger with
0and then with an empty string ('') and check if both were logged in correctly.