Replaced deprecated markdown-to-react-components with marksy#1188
Merged
shilman merged 3 commits intostorybookjs:masterfrom Jun 5, 2017
Merged
Replaced deprecated markdown-to-react-components with marksy#1188shilman merged 3 commits intostorybookjs:masterfrom
markdown-to-react-components with marksy#1188shilman merged 3 commits intostorybookjs:masterfrom
Conversation
…in addon-info to use marksy
Member
|
Thanks @ranneyd for diagnosing the problem and then fixing it. You rock! 👊 Edited the PR description slightly. Code looks great. I'll test it out on my machine and merge if it works. Many thanks! |
markdown-to-react-components with marksy
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
=======================================
Coverage 13.31% 13.31%
=======================================
Files 199 199
Lines 4588 4588
Branches 531 540 +9
=======================================
Hits 611 611
+ Misses 3501 3492 -9
- Partials 476 485 +9
Continue to review full report at Codecov.
|
Contributor
Author
|
I actually had but I accidentally undid that change. Fixing now. |
Contributor
Author
|
@shilman try it now. Let me know how it goes! |
This was referenced Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1114
What I did
Looking at issue 1114 (#1114)...
The error came from a package called
markdown-to-react-components. Looking at this package's github (https://github.com/christianalfoni/markdown-to-react-components) it's clear that the package is deprecated. They recommend usingmarksy(https://github.com/cerebral/marksy).Marksy appears to be a fork of
markdown-to-react-componentsbecause the APIs are almost identical (namely, the configuration is exactly the same). This made swapping out the old version for the new one very easy, which is what I did. I also updated the name of the config (which can be passed as an argument to this addon) to reflect the new underlying mechanism.How to test