Fix app entrypoint bug in RN gestorybook#1280
Merged
Conversation
- replace APP_NAME in the correct file - add a warning if APP_NAME cannot be found
Collaborator
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 13.71% 13.73% +0.02%
==========================================
Files 207 207
Lines 4646 4638 -8
Branches 526 638 +112
==========================================
Hits 637 637
+ Misses 3542 3443 -99
- Partials 467 558 +91
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1277
What I did
How to test
Run
getstorybookin a fresh RN app and check the results