Added flow support to getstorybook upgrade#1289
Merged
shilman merged 4 commits intostorybookjs:masterfrom Jun 17, 2017
AugustinLF:add-parser-option-getstorybook
Merged
Added flow support to getstorybook upgrade#1289shilman merged 4 commits intostorybookjs:masterfrom AugustinLF:add-parser-option-getstorybook
shilman merged 4 commits intostorybookjs:masterfrom
AugustinLF:add-parser-option-getstorybook
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
=======================================
Coverage 13.76% 13.76%
=======================================
Files 201 201
Lines 4620 4620
Branches 508 510 +2
=======================================
Hits 636 636
- Misses 3537 3547 +10
+ Partials 447 437 -10
Continue to review full report at Codecov.
|
Member
|
@AugustinLF awesome -- great addition!! can you provide a simple example project to go along with it? |
ndelangen
approved these changes
Jun 15, 2017
Contributor
Author
|
Here is an example. Do you want me to rebase my branch on master? |
Member
|
I'll review in the next few hrs and will ask if I need anything 🙇 |
shilman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does work for me on a large flow typed codebase. I'm not sure if there's a cleaner way to pass the options to the generator, if you have any suggestion, don't hesitate, I'll update the PR!