Ensure we add the correct version of react-dom#1349
Merged
Conversation
We need to use an equal version to the `react` version the app is using. #1284
Codecov Report
@@ Coverage Diff @@
## master #1349 +/- ##
=======================================
Coverage 13.76% 13.76%
=======================================
Files 202 202
Lines 4621 4621
Branches 598 507 -91
=======================================
Hits 636 636
- Misses 3473 3552 +79
+ Partials 512 433 -79
Continue to review full report at Codecov.
|
shilman
approved these changes
Jun 23, 2017
Member
shilman
left a comment
There was a problem hiding this comment.
LGTM! This is also where CRNA puts it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1284
We need to use an equal version to the
reactversion the app is using.What I did
Looked in
package.json#dependencies.We could also look elsewhere (e.g.
devDependencies), but that's where RN will put it.How to test
@shilman maybe can test CRNA too?