Story Hierarchy - initial state bug fix#1401
Merged
shilman merged 7 commits intorelease/3.2from Jul 6, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.2 #1401 +/- ##
==============================================
+ Coverage 15.82% 15.9% +0.07%
==============================================
Files 237 237
Lines 5043 5050 +7
Branches 625 619 -6
==============================================
+ Hits 798 803 +5
- Misses 3725 3729 +4
+ Partials 520 518 -2
Continue to review full report at Codecov.
|
shilman
reviewed
Jul 4, 2017
| currentSelectedHierarchy.length === nextSelectedHierarchy.length && | ||
| currentSelectedHierarchy.every((item, index) => item === nextSelectedHierarchy[index]) | ||
| ) { | ||
| return; |
Member
There was a problem hiding this comment.
if(!deepEquals(currentHierarchy, nextHierarchy)) {
const selectedNodes ...
}
shilman
approved these changes
Jul 6, 2017
This was referenced Jul 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #151
What I did
I've added
componentWillReceivePropsto thestories_tree/index.jsthat will recalculate the selected nodes according to the provided selected hierarchy.How to test
run
cra-kitchen-sink