Knobs: fix label alignment#1471
Merged
shilman merged 2 commits intostorybookjs:masterfrom Jul 15, 2017
Hypnosphi:patch-1
Merged
Knobs: fix label alignment#1471shilman merged 2 commits intostorybookjs:masterfrom Hypnosphi:patch-1
shilman merged 2 commits intostorybookjs:masterfrom
Hypnosphi:patch-1
Conversation
#1086 introduced increased font size for labels. Unfortunately, that broke alignment. This PR fixes it
Codecov Report
@@ Coverage Diff @@
## master #1471 +/- ##
=======================================
Coverage 14.34% 14.34%
=======================================
Files 201 201
Lines 4614 4614
Branches 503 497 -6
=======================================
Hits 662 662
Misses 3527 3527
Partials 425 425
Continue to review full report at Codecov.
|
To match that of a one-line TextType textarea
shilman
approved these changes
Jul 15, 2017
Member
shilman
left a comment
There was a problem hiding this comment.
Thanks @Hypnosphi looks great!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
#1086 introduced increased font size for labels. Unfortunately, that broke alignment
What I did
Lowered the
padding-topHow to test
Run any story with knobs addon
Before:


After: