Add sidebarAnimations config prop#1601
Merged
ndelangen merged 2 commits intostorybookjs:masterfrom Aug 5, 2017
Merged
Conversation
Closed
Codecov Report
@@ Coverage Diff @@
## master #1601 +/- ##
==========================================
- Coverage 21.05% 20.42% -0.63%
==========================================
Files 244 241 -3
Lines 5311 5254 -57
Branches 669 666 -3
==========================================
- Hits 1118 1073 -45
+ Misses 3670 3654 -16
- Partials 523 527 +4
Continue to review full report at Codecov.
|
Member
|
In fact, we can think about using CSS transitions instead of JS animation provided by react-treebeard to make things less laggy with heavy stories. But an ability to completely opt out of animations won't hurt anyway |
Member
|
whether it will lead to the fact that in the future we will have a bunch of options for tweaking UI? I guess we'll able to provide the same options via UI components when it's ready |
Member
|
Indeed @usulpro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
add option
sidebarAnimationswhich allows to disable sidebar tree animation. By default animations are enabledHow to test