Option to select an addon panel && rename selectedDownPanel to selectedAddonPanel#1641
Merged
Option to select an addon panel && rename selectedDownPanel to selectedAddonPanel#1641
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
+ Coverage 21.3% 21.41% +0.11%
==========================================
Files 244 244
Lines 5384 5402 +18
Branches 665 667 +2
==========================================
+ Hits 1147 1157 +10
- Misses 3732 3735 +3
- Partials 505 510 +5
Continue to review full report at Codecov.
|
Member
|
|
Member
Author
|
Done! |
amacleay
added a commit
to amacleay/DefinitelyTyped
that referenced
this pull request
Jun 18, 2018
16 tasks
amacleay
added a commit
to amacleay/DefinitelyTyped
that referenced
this pull request
Jun 18, 2018
Member
|
For the record (for those googling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #811
we had
selectedDownPaneloption in our UI module but it wasn't available bysetOptionsWhat I did
Allow to set
selectedDownPanelbysetOptions.Now it's possible to select the spesific addon panel this way:
You need to pass a panel ID to select a panel (same value that you pass to
addons.addPanel())If you don't know the ID you can pass anything and find in the console output the list of all registered
panels
How to test
run
cra-kitchen-sinkCheck out "Button" section. Selecting stories with different addons you'll see appropriate addon panels auto selected
Try to pass
nullor something else.