Skip to content

Upgrade react-modal to v2.2.4#1666

Merged
ndelangen merged 1 commit intostorybookjs:masterfrom
dsblv:upgrade-react-modal
Aug 16, 2017
Merged

Upgrade react-modal to v2.2.4#1666
ndelangen merged 1 commit intostorybookjs:masterfrom
dsblv:upgrade-react-modal

Conversation

@dsblv
Copy link
Copy Markdown
Contributor

@dsblv dsblv commented Aug 16, 2017

Issue:

Storybook was hard crashing if used alongside React 16 beta release.

What I did

I followed error stack traces and found out that the isue was caused by react-modal package that used long gone React.DOM.* helpers.

I swapped it out with the latest version, and it worked! Turns out react-modal had a major release since the dependent-upon 1.7.7, but according to changelog, it went without breaking changes.

I never used seach UI (which uses react-modal) before, but it seems to be working fine.

How to test

  • Set up a react project with storybook
  • npm install --save react@next react-dom@next
  • Run storybook, open http://localhost:9009/
  • Expect it not to fail right away
  • Try searching for something

@ndelangen ndelangen merged commit c249679 into storybookjs:master Aug 16, 2017
@ndelangen
Copy link
Copy Markdown
Member

Thank you,

Tested locally, works fine ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants