Added error message for missing or invalid storyName#747
Merged
ndelangen merged 3 commits intostorybookjs:masterfrom May 19, 2017
danielduan:storyname
Merged
Added error message for missing or invalid storyName#747ndelangen merged 3 commits intostorybookjs:masterfrom danielduan:storyname
ndelangen merged 3 commits intostorybookjs:masterfrom
danielduan:storyname
Conversation
Member
|
Don't mind the failing build, nodejs.org seems to be having difficulties. |
ndelangen
approved these changes
Apr 4, 2017
Member
|
Thanks for the PR! |
thani-sh
approved these changes
Apr 4, 2017
Contributor
|
LGTM 👍 |
Member
|
last rebase, I'll merge it this time. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8cf3ed8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #722
Added a check for storyName type to catch missing or invalid storyName.