Add typescript definitions for getStorybook()#753
Merged
ndelangen merged 7 commits intostorybookjs:masterfrom Apr 20, 2017
Merged
Add typescript definitions for getStorybook()#753ndelangen merged 7 commits intostorybookjs:masterfrom
ndelangen merged 7 commits intostorybookjs:masterfrom
Conversation
`2.35.3` add `getStorybook()` in 86d5819, but Typescript definitions were not updated.
joscha
commented
Apr 10, 2017
| render: RenderFunction, | ||
| }; | ||
|
|
||
| type StoryBucket = { |
Member
Author
There was a problem hiding this comment.
Not 100% sure about the naming here, happy to take any suggestion.
Member
Author
|
Updated to not overwrite the changes from #680 |
Member
Author
|
@ndelangen any chance to get this in if I rebase it again? |
Member
|
Yeah, I think so! |
ndelangen
approved these changes
Apr 19, 2017
Member
Author
|
👍 @ndelangen rebased! |
Member
Author
|
ta! |
Member
Author
|
any chance to get this in a release @ndelangen? |
Member
|
Yes this will get released in 3.0.0, I don't have a date for that yet, should be an alpha release soonish. My guess this at the end of this month or in the beginning of next month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.35.3addgetStorybook()in 86d5819, but Typescript definitions were not updated.Also
configurewas missing altogether, added in 0e9d7deIssue:
when using
getStorybook().What I did
Added TS definition.
How to test
Run
test.ts, e.g.:with
tsc.