Conversation
shilman
approved these changes
Apr 18, 2017
Member
shilman
left a comment
shilman
left a comment
There was a problem hiding this comment.
Great change! See minor comment above.
| const path = require('path'); | ||
| const shell = require('shelljs'); | ||
| const chalk = require('chalk'); | ||
| const babel = ['node_modules', '.bin', 'babel'].join(path.sep); |
Member
Author
|
Thanks, @shilman! |
Member
Author
|
So if nobody objects I will merge this? |
Member
|
@usulpro Are you working on getting this merged? |
Member
Author
|
Yes @ndelangen I'll resolve it |
use ./scripts/prepublish.js as a prepublish script for all packages
stories -> stories/ to ignore only folders added test.js
usulpro
force-pushed
the
shellJs_scripts
branch
from
02f2a2e to
4845e21
Compare
This was referenced Jan 22, 2020
This was referenced Jan 12, 2022
|
View your CI Pipeline Execution ↗ for commit 4845e21.
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: All packages use different versions of prepublish scripts. Plus some of them
shellscripts which have bad compatibility with windowsWhat I did
Added the only instance of prepublish script to
./scripts/prepublish.jsit's the shell js version wich allready was used in
storybook-uiChanged in
scriptsof eachpackage.jsonto"prepublish": "node ../../scripts/prepublish.js"Removed previos versions of prepublish scripts from packages
How to test
yarnit should install all dependencies without any errors and buid
dist's for all packages