#959 add a max-height and center element with alignItems: center#961
Merged
ndelangen merged 4 commits intostorybookjs:masterfrom Apr 28, 2017
wcastand:master
Merged
#959 add a max-height and center element with alignItems: center#961ndelangen merged 4 commits intostorybookjs:masterfrom wcastand:master
ndelangen merged 4 commits intostorybookjs:masterfrom
wcastand:master
Conversation
Member
|
@wcastand thanks for PR. Consider applying maxHeight and overflow to the |
Contributor
Author
|
I put max-Height in the tablink style. Thanks for the help on this :) We should update the doc too but i can't find it and my english is far from perfect for a documentation :/ |
usulpro
reviewed
Apr 27, 2017
| justifyContent: 'flex-start', | ||
| alignItems: 'center', | ||
| maxHeight: 60, | ||
| overflow: 'hidden', |
Member
There was a problem hiding this comment.
just remove it from here:
maxHeight: 60,
overflow: 'hidden',
usulpro
suggested changes
Apr 27, 2017
Member
usulpro
left a comment
usulpro
left a comment
There was a problem hiding this comment.
remove
maxHeight: 60,
overflow: 'hidden',
from tabbar
Contributor
Author
|
I think we're good now :) |
ndelangen
approved these changes
Apr 28, 2017
Member
ndelangen
left a comment
ndelangen
left a comment
There was a problem hiding this comment.
Looks good to me, tested locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #959
I'm not sure i did the things right (never used lerna so i was a bit lost ). Let me know if i missed something.
What I did
I added some style to the tabtitles to center his children.
How to test
In the example, add a react component as a Title with an
buttonfor example and some padding or margin.