Added typescript definition to addon notes#989
Merged
ndelangen merged 3 commits intostorybookjs:masterfrom May 10, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
=======================================
Coverage 12.61% 12.61%
=======================================
Files 192 192
Lines 4424 4424
Branches 707 707
=======================================
Hits 558 558
Misses 3241 3241
Partials 625 625Continue to review full report at Codecov.
|
ndelangen
approved these changes
May 10, 2017
Member
|
@fabien0102 Thank you for this PR! It looks good, I'll merge it. |
ndelangen
changed the title
shilman
changed the title
ghost
mentioned this pull request
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 666b7b2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #953
What I did
Add typescript definition to add-notes addons
How to test
I test locally on my current project, you can have a look here
Note
The package.json seams to be with CRLF before, it explain the wtf diff (I've only added
typesanddevDepencencies/@types/react)