Skip to content

Commit 252ed4a

Browse files
committed
fix windows compilation (#1302)
1 parent 7b7ac8e commit 252ed4a

File tree

1 file changed

+14
-2
lines changed

1 file changed

+14
-2
lines changed

libheif/box.cc

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,14 +1413,18 @@ void Box_iloc::set_use_tmp_file(bool flag)
14131413
{
14141414
m_use_tmpfile = flag;
14151415
if (flag) {
1416-
#if !defined(_WIN32) && !defined(_WIN64)
1416+
#if !defined(_WIN32)
14171417
strcpy(m_tmp_filename, "/tmp/libheif-XXXXXX");
14181418
m_tmpfile_fd = mkstemp(m_tmp_filename);
14191419
#else
1420+
// TODO Currently unused code. Implement when needed.
1421+
assert(false);
1422+
# if 0
14201423
char tmpname[L_tmpnam_s];
14211424
// TODO: check return value (errno_t)
14221425
tmpnam_s(tmpname, L_tmpnam_s);
14231426
_sopen_s(&m_tmpfile_fd, tmpname, _O_CREAT | _O_TEMPORARY | _O_TRUNC | _O_RDWR, _SH_DENYRW, _S_IREAD | _S_IWRITE);
1427+
# endif
14241428
#endif
14251429
}
14261430
}
@@ -1643,10 +1647,14 @@ Error Box_iloc::append_data(heif_item_id item_ID,
16431647
extent.length = data.size();
16441648

16451649
if (m_use_tmpfile && construction_method==0) {
1646-
#if !defined(_WIN32) && !defined(_WIN64)
1650+
#if !defined(_WIN32)
16471651
ssize_t cnt = ::write(m_tmpfile_fd, data.data(), data.size());
16481652
#else
1653+
// TODO Currently unused code. Implement when needed.
1654+
assert(false);
1655+
# if 0
16491656
int cnt = _write(m_tmpfile_fd, data.data(), data.size());
1657+
# endif
16501658
#endif
16511659
if (cnt < 0) {
16521660
std::stringstream sstr;
@@ -1904,7 +1912,11 @@ Error Box_iloc::write_mdat_after_iloc(StreamWriter& writer)
19041912
#if !defined(_WIN32) && !defined(_WIN64)
19051913
ssize_t cnt = ::read(m_tmpfile_fd, data.data(), extent.length);
19061914
#else
1915+
// TODO Currently unused code. Implement when needed.
1916+
assert(false);
1917+
# if 0
19071918
int cnt = _read(m_tmpfile_fd, data.data(), extent.length);
1919+
# endif
19081920
#endif
19091921
if (cnt<0) {
19101922
std::stringstream sstr;

0 commit comments

Comments
 (0)