Merge pull request flutter#10 from mit-mit/master

Make image links work

Author: mit-mit

packages/flutter_markdown/CHANGELOG.md

@@ -0,0 +1,9 @@
+## 0.1.0
+
+* Roll the dependency on `markdown` to 1.0.0
+* Add a test and example for image links
+* Fix the `onTap` callback on hyperlinks
+
+## 0.0.9
+
+* First published version

packages/flutter_markdown/example/demo.dart

@@ -5,7 +5,7 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_markdown/flutter_markdown.dart';
 
-const String _kMarkdownData = """# Markdown Example
+const String _markdownData = """# Markdown Example
 Markdown allows you to easily include formatted text, images, and even formatted Dart code in your app.
 
 ## Styling
@@ -18,11 +18,31 @@ Style text as _italic_, __bold__, or `inline code`.
 ## Links
 You can use [hyperlinks](hyperlink) in markdown
 
-## Code blocks
-Formatted Dart code looks really pretty too. This is an example of how to create your own Markdown widget:
+## Images
+
+You can include images:
+
+![Flutter logo](https://flutter.io/images/flutter-mark-square-100.png#100x100)
+
+## Markdown widget
+
+This is an example of how to create your own Markdown widget:
 
     new Markdown(data: 'Hello _world_!');
 
+## Code blocks
+Formatted Dart code looks really pretty too:
+
+```
+void main() {
+  runApp(new MaterialApp(
+    home: new Scaffold(
+      body: new Markdown(data: markdownData)
+    )
+  ));
+}
+```
+
 Enjoy!
 """;
 
@@ -31,7 +51,7 @@ void main() {
     title: "Markdown Demo",
     home: new Scaffold(
       appBar: new AppBar(title: const Text('Markdown Demo')),
-      body: const Markdown(data: _kMarkdownData)
+      body: const Markdown(data: _markdownData)
     )
   ));
 }

packages/flutter_markdown/pubspec.yaml

@@ -2,12 +2,12 @@ name: flutter_markdown
 author: Flutter Authors <flutter-dev@googlegroups.com>
 description: A markdown renderer for Flutter.
 homepage: https://github.com/flutter/flutter_markdown
-version: 0.0.10
+version: 0.1.0
 
 dependencies:
   flutter:
     sdk: flutter
-  markdown: ^0.11.0
+  markdown: ^1.0.0
   meta: ^1.0.5
   string_scanner: ^1.0.0
 

packages/flutter_markdown/test/flutter_markdown_test.dart

@@ -163,6 +163,18 @@ void main() {
       expect(tapResults, orderedEquals(['firstHref', 'secondHref']));
     });
   });
+  
+  testWidgets('Image links', (WidgetTester tester) async {
+    await tester
+        .pumpWidget(_boilerplate(const Markdown(data: '![alt](img#50x50)')));
+
+    final Image image =
+      tester.allWidgets.firstWhere((Widget widget) => widget is Image);
+    final NetworkImage networkImage = image.image;
+    expect(networkImage.url, 'img');
+    expect(image.width, 50);
+    expect(image.height, 50);
+  });
 
   testWidgets('HTML tag ignored ', (WidgetTester tester) async {
     final List<String> mdData = <String>[