Skip to content

Commit bf76bb9

Browse files
committed
feedback-task: created ref_type oneof field
Created a oneof field, "ref_type," (should expand to `ref_type_case` for generated code) that captures both types of references. The old type, subtree_ordinal, has also been deprecated. This addresses feedback in the PR tagged below. PR: #726
1 parent 79b6935 commit bf76bb9

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

proto/substrait/algebra.proto

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1737,9 +1737,11 @@ message AggregateFunction {
17371737
// This rel is used to create references,
17381738
// in case we refer to a RelRoot field names will be ignored
17391739
message ReferenceRel {
1740-
// points to a PlanRel in Plan.relations (ordinal reference)
1741-
int32 subtree_ordinal = 1;
1740+
oneof ref_type {
1741+
// points to a PlanRel in Plan.relations (ordinal reference)
1742+
int32 subtree_ordinal = 1 [deprecated = true];
17421743

1743-
// points to a subtree_anchor in PlanRel (for non-ordinal reference)
1744-
uint32 subtree_reference = 2;
1744+
// points to a subtree_anchor in PlanRel (for non-ordinal reference)
1745+
uint32 subtree_reference = 2;
1746+
}
17451747
}

0 commit comments

Comments
 (0)