feat(version): honor shared output settings (#49)

Author: matoous

internal/buildinfo/buildinfo.go

@@ -15,6 +15,14 @@ var (
 	Date = "unknown"
 )
 
+// Details describes the current CLI build metadata.
+type Details struct {
+	Version string `json:"version"`
+	Commit  string `json:"commit"`
+	Date    string `json:"date"`
+	Dirty   bool   `json:"dirty"`
+}
+
 func info() (version, commit, date string, dirty bool) {
 	version = Version
 	commit = Commit
@@ -47,20 +55,31 @@ func info() (version, commit, date string, dirty bool) {
 	return version, commit, date, dirty
 }
 
+// Current returns the current build metadata as a structured value.
+func Current() Details {
+	version, commit, date, dirty := info()
+	return Details{
+		Version: version,
+		Commit:  commit,
+		Date:    date,
+		Dirty:   dirty,
+	}
+}
+
 // Short returns a concise version string suitable for --version output.
 func Short() string {
-	version, commit, _, dirty := info()
+	current := Current()
 
 	var parts []string
-	parts = append(parts, version)
-	if commit != "" && commit != "unknown" {
-		shortCommit := commit
+	parts = append(parts, current.Version)
+	if current.Commit != "" && current.Commit != "unknown" {
+		shortCommit := current.Commit
 		if len(shortCommit) > 7 {
 			shortCommit = shortCommit[:7]
 		}
 		parts = append(parts, shortCommit)
 	}
-	if dirty {
+	if current.Dirty {
 		parts = append(parts, "dirty")
 	}
 
@@ -69,11 +88,11 @@ func Short() string {
 
 // Long returns full build details.
 func Long() string {
-	version, commit, date, _ := info()
+	current := Current()
 	return fmt.Sprintf(
 		"Version: %s\nCommit: %s\nDate: %s",
-		version,
-		commit,
-		date,
+		current.Version,
+		current.Commit,
+		current.Date,
 	)
 }

internal/commands/version/version.go

@@ -6,17 +6,28 @@ import (
 
 	"github.com/urfave/cli/v3"
 
+	"github.com/sumup/sumup-cli/internal/app"
 	"github.com/sumup/sumup-cli/internal/buildinfo"
+	"github.com/sumup/sumup-cli/internal/display"
 )
 
 // NewCommand returns the version command.
 func NewCommand() *cli.Command {
 	return &cli.Command{
 		Name:  "version",
 		Usage: "Print CLI build information",
-		Action: func(_ context.Context, _ *cli.Command) error {
-			fmt.Println(buildinfo.Long())
-			return nil
+		Action: func(_ context.Context, cmd *cli.Command) error {
+			appCtx, err := app.GetAppContext(cmd)
+			if err != nil {
+				return err
+			}
+
+			if appCtx.JSONOutput {
+				return display.PrintJSON(appCtx.Output, buildinfo.Current())
+			}
+
+			_, err = fmt.Fprintln(appCtx.Output, buildinfo.Long())
+			return err
 		},
 	}
 }

internal/commands/version/version_test.go

@@ -0,0 +1,42 @@
+package version
+
+import (
+	"bytes"
+	"context"
+	"strings"
+	"testing"
+
+	"github.com/sumup/sumup-cli/internal/app"
+)
+
+func TestVersionCommandWritesToAppOutput(t *testing.T) {
+	var out bytes.Buffer
+	cmd := NewCommand()
+	cmd.Metadata = map[string]any{
+		app.ContextKey: &app.Context{Output: &out},
+	}
+
+	if err := cmd.Action(context.Background(), cmd); err != nil {
+		t.Fatalf("Action() error = %v", err)
+	}
+
+	if !strings.Contains(out.String(), "Version:") {
+		t.Fatalf("Action() output = %q, want version details", out.String())
+	}
+}
+
+func TestVersionCommandPrintsJSONWhenRequested(t *testing.T) {
+	var out bytes.Buffer
+	cmd := NewCommand()
+	cmd.Metadata = map[string]any{
+		app.ContextKey: &app.Context{Output: &out, JSONOutput: true},
+	}
+
+	if err := cmd.Action(context.Background(), cmd); err != nil {
+		t.Fatalf("Action() error = %v", err)
+	}
+
+	if !strings.Contains(out.String(), `"version"`) {
+		t.Fatalf("Action() output = %q, want JSON payload", out.String())
+	}
+}