test: align package boundaries and assertions (#61)

Author: matoous

internal/commands/context/context_internal_test.go

@@ -0,0 +1,56 @@
+package context
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	sumup "github.com/sumup/sumup-go"
+)
+
+func TestModelUpdate(t *testing.T) {
+	t.Run("ignores stale search results", func(t *testing.T) {
+		currentItems := []sumup.Membership{{Resource: sumup.MembershipResource{ID: "current"}}}
+		m := model{
+			currentLevel:   navigationLevel{memberships: currentItems},
+			displayed:      currentItems,
+			loading:        true,
+			activeSearchID: 2,
+		}
+
+		updated, cmd := m.Update(searchResultMsg{
+			requestID:   1,
+			memberships: []sumup.Membership{{Resource: sumup.MembershipResource{ID: "stale"}}},
+		})
+
+		assert.Nil(t, cmd)
+
+		got, ok := updated.(model)
+		require.True(t, ok)
+		assert.True(t, got.loading)
+		require.NotEmpty(t, got.displayed)
+		assert.Equal(t, "current", got.displayed[0].Resource.ID)
+	})
+
+	t.Run("applies active search results", func(t *testing.T) {
+		m := model{
+			currentLevel:   navigationLevel{},
+			displayed:      nil,
+			loading:        true,
+			activeSearchID: 3,
+		}
+
+		updated, cmd := m.Update(searchResultMsg{
+			requestID:   3,
+			memberships: []sumup.Membership{{Resource: sumup.MembershipResource{ID: "fresh"}}},
+		})
+
+		assert.Nil(t, cmd)
+
+		got, ok := updated.(model)
+		require.True(t, ok)
+		assert.False(t, got.loading)
+		require.Len(t, got.displayed, 1)
+		assert.Equal(t, "fresh", got.displayed[0].Resource.ID)
+	})
+}

internal/commands/context/context_test.go

@@ -0,0 +1,37 @@
+package members
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"github.com/sumup/sumup-cli/internal/app"
+)
+
+func TestRenderDeleteMemberResult(t *testing.T) {
+	t.Run("prints json acknowledgement when requested", func(t *testing.T) {
+		var out bytes.Buffer
+
+		appCtx := &app.Context{
+			JSONOutput: true,
+			Output:     &out,
+		}
+
+		err := renderDeleteMemberResult(appCtx)
+
+		require.NoError(t, err)
+		assert.Contains(t, out.String(), `"status": "deleted"`)
+	})
+
+	t.Run("writes status message in human mode", func(t *testing.T) {
+		var statusOut bytes.Buffer
+
+		appCtx := &app.Context{StatusOutput: &statusOut}
+
+		err := renderDeleteMemberResult(appCtx)
+
+		require.NoError(t, err)
+		assert.Contains(t, statusOut.String(), "Member deleted")
+	})
+}

internal/commands/members/members_output_internal_test.go

@@ -0,0 +1,49 @@
+package merchants
+
+import (
+	"bytes"
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	sumup "github.com/sumup/sumup-go"
+
+	"github.com/sumup/sumup-cli/internal/app"
+)
+
+func TestRenderMerchant(t *testing.T) {
+	t.Run("renders merchant and business profile details", func(t *testing.T) {
+		var out bytes.Buffer
+		createdAt := time.Date(2026, time.March, 27, 10, 0, 0, 0, time.UTC)
+		updatedAt := createdAt.Add(2 * time.Hour)
+		alias := "Main account"
+		businessName := "Example Shop"
+		businessEmail := "shop@example.com"
+		businessWebsite := "https://example.com"
+		sandbox := true
+
+		err := renderMerchant(&app.Context{Output: &out, ExactTimestamps: true}, &sumup.Merchant{
+			MerchantCode:    "M123",
+			Alias:           &alias,
+			Country:         "DE",
+			DefaultCurrency: "EUR",
+			DefaultLocale:   "de-DE",
+			Sandbox:         &sandbox,
+			CreatedAt:       createdAt,
+			UpdatedAt:       updatedAt,
+			BusinessProfile: &sumup.BusinessProfile{
+				Name:    &businessName,
+				Email:   &businessEmail,
+				Website: &businessWebsite,
+			},
+		})
+
+		require.NoError(t, err)
+
+		rendered := out.String()
+		for _, want := range []string{"M123", "Main account", "Example Shop", "shop@example.com", "https://example.com"} {
+			assert.Contains(t, rendered, want)
+		}
+	})
+}

internal/commands/members/members_output_test.go

@@ -0,0 +1,58 @@
+package readers
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	sumup "github.com/sumup/sumup-go"
+	"github.com/urfave/cli/v3"
+)
+
+func TestNewCommand(t *testing.T) {
+	t.Run("reader context-aware commands do not require merchant code", func(t *testing.T) {
+		cmd := NewCommand()
+
+		for _, name := range []string{"get", "update", "terminate"} {
+			subcommand := findSubcommand(t, cmd, name)
+			flag := findStringFlag(t, subcommand, "merchant-code")
+			assert.False(t, flag.Required, "%s merchant-code flag should allow context fallback", name)
+		}
+	})
+}
+
+func TestFormatCreateReaderError(t *testing.T) {
+	t.Run("wraps sparse problem responses without panicking", func(t *testing.T) {
+		err := formatCreateReaderError(&sumup.Problem{})
+
+		require.Error(t, err)
+		assert.Contains(t, err.Error(), "create reader:")
+	})
+}
+
+func findSubcommand(t *testing.T, cmd *cli.Command, name string) *cli.Command {
+	t.Helper()
+
+	for _, subcommand := range cmd.Commands {
+		if subcommand.Name == name {
+			return subcommand
+		}
+	}
+
+	require.Failf(t, "subcommand not found", "subcommand %q not found", name)
+	return nil
+}
+
+func findStringFlag(t *testing.T, cmd *cli.Command, name string) *cli.StringFlag {
+	t.Helper()
+
+	for _, flag := range cmd.Flags {
+		stringFlag, ok := flag.(*cli.StringFlag)
+		if ok && stringFlag.Name == name {
+			return stringFlag
+		}
+	}
+
+	require.Failf(t, "string flag not found", "string flag %q not found on %s", name, cmd.Name)
+	return nil
+}