feat(api)!: remove magic service properties from SumUp

Drop property-based service access and keep explicit service methods as the only public SDK entrypoint (e.g. checkouts()).

Update README, examples, and tests to use method-based access consistently.

Align the dormant codegen SumUp template with method-only service access.

BREAKING CHANGE: property access like $sumup->checkouts is no longer supported; use $sumup->checkouts() instead.

Author: matoous

README.md

@@ -37,7 +37,7 @@ try {
     // SDK automatically uses SUMUP_API_KEY environment variable
     $sumup = new \SumUp\SumUp();
 
-    $checkout = $sumup->checkouts->create([
+    $checkout = $sumup->checkouts()->create([
         'amount' => 10.00,
         'currency' => 'EUR',
         'checkout_reference' => 'your-checkout-ref',
@@ -119,7 +119,7 @@ $sumup = new \SumUp\SumUp([
 
 ## API Reference
 
-For a full list of available services and methods, explore the `src/Services/` directory or check the inline documentation in the code.
+For a full list of available services and methods, explore the service files under `src/*/*.php` (for example `src/Checkouts/Checkouts.php`) or check the inline documentation in the code.
 
 ## License
 

codegen/pkg/generator/sumup.go

@@ -7,7 +7,6 @@ import (
 	"os"
 	"path/filepath"
 	"slices"
-	"strings"
 
 	"github.com/iancoleman/strcase"
 )
@@ -51,13 +50,7 @@ namespace SumUp;
  * Class SumUp
  *
  * @package SumUp
-`)
-
-	if propertyDocs := renderSumUpPropertyDocs(services); propertyDocs != "" {
-		buf.WriteString(propertyDocs)
-	}
-
-	buf.WriteString(` */
+ */
 class SumUp
 {
     /**
@@ -74,12 +67,7 @@ class SumUp
 
 `)
 
-	if serviceMap := renderSumUpServiceMap(services); serviceMap != "" {
-		buf.WriteString(serviceMap)
-	}
-
 	buf.WriteString(`
-
     /**
      * SumUp constructor.
      *
@@ -160,30 +148,20 @@ class SumUp
         return $config;
     }
 
-    /**
-     * Proxy access to services via properties.
-     *
-     * @param string $name
-     *
-     * @return SumUpService|null
-     */
-    public function __get($name)
-    {
-        if (!array_key_exists($name, self::$serviceClassMap)) {
-            trigger_error('Undefined property: ' . static::class . '::$' . $name);
-
-            return null;
-        }
-
-        if (empty($this->accessToken)) {
-            throw new ConfigurationException('No access token provided');
-        }
+`)
 
-        $token = $this->accessToken;
-        $serviceClass = self::$serviceClassMap[$name];
+	for _, service := range services {
+		method := strcase.ToLowerCamel(service)
+		fmt.Fprintf(&buf, "    public function %s()\n", method)
+		buf.WriteString("    {\n")
+		buf.WriteString("        if (empty($this->accessToken)) {\n")
+		buf.WriteString("            throw new ConfigurationException('No access token provided');\n")
+		buf.WriteString("        }\n\n")
+		fmt.Fprintf(&buf, "        return new %s($this->client, $this->accessToken);\n", service)
+		buf.WriteString("    }\n\n")
+	}
 
-        return new $serviceClass($this->client, $token);
-    }
+	buf.WriteString(`
 }
 `)
 
@@ -236,7 +214,6 @@ func sumUpUseStatements(serviceNames []string) []string {
 	}
 
 	serviceSet := map[string]struct{}{
-		"SumUp\\Services\\SumUpService": {},
 	}
 
 	for _, name := range serviceNames {
@@ -248,39 +225,3 @@ func sumUpUseStatements(serviceNames []string) []string {
 
 	return append(uses, serviceUses...)
 }
-
-//nolint:unused // helper for generating the SumUp class docblocks
-func renderSumUpPropertyDocs(serviceNames []string) string {
-	if len(serviceNames) == 0 {
-		return ""
-	}
-
-	var buf strings.Builder
-	buf.WriteString(" *\n")
-	for _, service := range serviceNames {
-		fmt.Fprintf(&buf, " * @property %s $%s\n", service, strcase.ToLowerCamel(service))
-	}
-
-	return buf.String()
-}
-
-//nolint:unused // helper for generating the SumUp class service map
-func renderSumUpServiceMap(serviceNames []string) string {
-	if len(serviceNames) == 0 {
-		return ""
-	}
-
-	var buf strings.Builder
-	buf.WriteString("    /**\n")
-	buf.WriteString("     * Map of property names to service classes.\n")
-	buf.WriteString("     *\n")
-	buf.WriteString("     * @var array<string, string>\n")
-	buf.WriteString("     */\n")
-	buf.WriteString("    private static $serviceClassMap = [\n")
-	for _, service := range serviceNames {
-		fmt.Fprintf(&buf, "        '%s' => %s::class,\n", strcase.ToLowerCamel(service), service)
-	}
-	buf.WriteString("    ];\n\n")
-
-	return buf.String()
-}

examples/custom-http-client.php

@@ -35,14 +35,14 @@
  */
 class CustomLoggingHttpClient implements \SumUp\HttpClient\HttpClientInterface
 {
-    private $wrappedClient;
+    private \SumUp\HttpClient\HttpClientInterface $wrappedClient;
 
     public function __construct(\SumUp\HttpClient\HttpClientInterface $wrappedClient)
     {
         $this->wrappedClient = $wrappedClient;
     }
 
-    public function send($method, $url, $body, $headers, $options = null)
+    public function send(string $method, string $url, array $body, array $headers, ?array $options = null): \SumUp\HttpClient\Response
     {
         // Log the request
         echo "[HTTP Request] {$method} {$url}\n";
@@ -54,7 +54,7 @@ public function send($method, $url, $body, $headers, $options = null)
         $response = $this->wrappedClient->send($method, $url, $body, $headers, $options);
 
         // Log the response
-        echo "[HTTP Response] Status: " . $response->getHttpStatusCode() . "\n";
+        echo "[HTTP Response] Status: " . $response->getHttpResponseCode() . "\n";
 
         return $response;
     }
@@ -83,7 +83,7 @@ public function send($method, $url, $body, $headers, $options = null)
 
 // Use the SDK normally - all requests will be logged
 try {
-    $merchant = $sumup->merchants->get($merchantCode);
+    $merchant = $sumup->merchants()->get($merchantCode);
     echo "\nMerchant retrieved successfully!\n";
     echo "Merchant code: " . $merchant->merchantCode . "\n";
 } catch (\SumUp\Exception\SDKException $e) {

examples/guzzle-http-client.php

@@ -35,7 +35,7 @@
 ]);
 
 try {
-    $merchant = $sumup->merchants->get($merchantCode);
+    $merchant = $sumup->merchants()->get($merchantCode);
     echo "\nMerchant retrieved successfully!\n";
     echo "Merchant code: " . $merchant->merchantCode . "\n";
 } catch (\SumUp\Exception\SDKException $e) {

examples/oauth2/README.md

@@ -86,7 +86,7 @@ $sumup = new \SumUp\SumUp();
 $sumup->setDefaultAccessToken($accessToken);
 
 // Use the SDK normally
-$checkout = $sumup->checkouts->create([
+$checkout = $sumup->checkouts()->create([
     'amount' => 10.00,
     'currency' => 'EUR',
     'checkout_reference' => 'order-123',

examples/oauth2/oauth2-server.php

@@ -154,7 +154,7 @@ function handleCallback(GenericProvider $provider): void
         if ($defaultMerchantCode) {
             echo '<h2>Merchant Information:</h2>';
             try {
-                $merchant = $sumup->merchants->get($defaultMerchantCode);
+                $merchant = $sumup->merchants()->get($defaultMerchantCode);
                 echo '<pre>' . htmlspecialchars(json_encode($merchant, JSON_PRETTY_PRINT)) . '</pre>';
             } catch (Exception $e) {
                 echo '<p style="color: red;">Error fetching merchant: ' . htmlspecialchars($e->getMessage()) . '</p>';
@@ -177,7 +177,7 @@ function handleCallback(GenericProvider $provider): void
     \'access_token\' => \'' . $accessToken->getToken() . '\',
 ]);
 
-$checkout = $sumup->checkouts->create([
+$checkout = $sumup->checkouts()->create([
     \'amount\' => 10.00,
     \'currency\' => \'EUR\',
     \'checkout_reference\' => \'my-order-123\',

examples/simple.php

@@ -33,7 +33,7 @@
 // $sumup->setDefaultAccessToken('your-token-here');
 
 // Use services with the default token
-$merchant = $sumup->merchants->get($merchantCode);
+$merchant = $sumup->merchants()->get($merchantCode);
 print_r($merchant);
 
 // Override the default token by creating a new client instance instead.