remove curves: these were taken care of already, add 'version' field to Runtime, send version along with prometheus

Author: jeromegn

Cargo.lock

@@ -29,4 +29,3 @@ config = "0.9"
 sha2 = "0.8"
 bytes = "*"
 prometheus = "0.4"
-floating-duration = "0.1"

distributed-fly/Cargo.toml

@@ -48,8 +48,6 @@ use tokio_openssl::SslAcceptorExt;
 #[macro_use]
 extern crate prometheus;
 
-use floating_duration::TimeAsFloat;
-
 mod cert;
 mod metrics;
 mod proxy;
@@ -70,10 +68,6 @@ lazy_static! {
         .unwrap();
 }
 
-static CURVES: &str = "ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-ECDSA-AES128-SHA:ECDHE-ECDSA-AES256-SHA:ECDHE-ECDSA-AES128-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-RSA-AES128-SHA:ECDHE-RSA-AES256-SHA:ECDHE-RSA-AES128-SHA256:ECDHE-RSA-AES256-SHA384:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:DHE-RSA-AES128-SHA:DHE-RSA-AES256-SHA:DHE-RSA-AES128-SHA256:DHE-RSA-AES256-SHA256";
-
-use std::time;
-
 fn main() {
     let env = Env::default().filter_or("LOG_LEVEL", "info");
     env_logger::init_from_env(env);
@@ -133,7 +127,6 @@ fn main() {
         openssl::ssl::select_next_proto(b"\x02h2\x08http/1.1", client)
             .ok_or(openssl::ssl::AlpnError::NOACK)
     });
-    tls_builder.set_cipher_list(CURVES).unwrap();
 
     let certs_path = {
         match GLOBAL_SETTINGS.read().unwrap().certs_path {
@@ -175,12 +168,12 @@ fn main() {
         .map_err(|e| error!("error in stream: {}", e))
         .for_each(move |stream| {
             let remote_addr = stream.peer_addr().unwrap();
-            let start = time::Instant::now();
+            let timer = TLS_HANDSHAKE_TIME_HISTOGRAM.start_timer();
             tls_acceptor
                 .accept_async(stream)
                 .map_err(|e| error!("error handshake conn: {}", e))
                 .and_then(move |stream| {
-                    TLS_HANDSHAKE_TIME_HISTOGRAM.observe(start.elapsed().as_fractional_secs());
+                    timer.observe_duration();
                     let h = hyper::server::conn::Http::new();
                     h.serve_connection(
                         stream,

distributed-fly/src/main.rs

@@ -75,9 +75,9 @@ impl RuntimeSelector for DistributedRuntimeSelector {
                         })),
                     }
                 };
-                let mut rt = Runtime::new(Some(rel.app.clone()), &settings);
+                let mut rt = Runtime::new(Some(rel.app_id.to_string()), Some(rel.version.to_string()), &settings);
                 let merged_conf = rel.clone().parsed_config().unwrap();
-                rt.eval(
+                rt.eval(    
                     "<app config>",
                     &format!("window.app = {{ config: {} }};", merged_conf),
                 );

distributed-fly/src/runtime_selector.rs

@@ -50,7 +50,7 @@ fn main() {
     .get_matches();
 
   let entry_file = matches.value_of("input").unwrap();
-  let mut runtime = Runtime::new(None, &SETTINGS.read().unwrap());
+  let mut runtime = Runtime::new(None, None, &SETTINGS.read().unwrap());
 
   debug!("Loading dev tools");
   runtime.eval_file("v8env/dist/dev-tools.js");

src/bin/dns/main.rs

@@ -29,7 +29,7 @@ fn main() {
         .index(1),
     ).get_matches();
 
-  let mut runtime = Runtime::new(None, &SETTINGS.read().unwrap());
+  let mut runtime = Runtime::new(None, None, &SETTINGS.read().unwrap());
   debug!("Loading dev tools");
   runtime.eval_file("v8env/dist/dev-tools.js");
   runtime.eval("<installDevTools>", "installDevTools();");

src/bin/eval/main.rs

@@ -59,7 +59,7 @@ fn main() {
     info!("V8 version: {}", libfly::version());
 
     let entry_file = matches.value_of("input").unwrap();
-    let mut runtime = Runtime::new(None, &SETTINGS.read().unwrap());
+    let mut runtime = Runtime::new(None, None, &SETTINGS.read().unwrap());
 
     debug!("Loading dev tools");
     runtime.eval_file("v8env/dist/dev-tools.js");

src/bin/http/main.rs

@@ -34,7 +34,7 @@ fn main() {
   let env = Env::default().filter_or("LOG_LEVEL", "info");
   env_logger::init_from_env(env);
 
-  let mut rt = Runtime::new(None, &SETTINGS.read().unwrap());
+  let mut rt = Runtime::new(None, None, &SETTINGS.read().unwrap());
   rt.eval("mocha.js", str::from_utf8(MOCHA_SOURCE).unwrap());
   rt.eval("chai.js", str::from_utf8(CHAI_SOURCE).unwrap());
   rt.eval("testing.js", str::from_utf8(FLY_TESTING_SOURCE).unwrap());

src/bin/test/main.rs

@@ -94,7 +94,7 @@ pub fn serve_http(
                 .status(StatusCode::SERVICE_UNAVAILABLE)
                 .body(Body::empty())
                 .unwrap(),
-            Some(rt.name.clone()),
+            Some((rt.name.clone(), rt.version.clone())),
         );
     }
 
@@ -138,7 +138,7 @@ pub fn serve_http(
                     .status(StatusCode::INTERNAL_SERVER_ERROR)
                     .body(Body::empty())
                     .unwrap(),
-                Some(rt.name.clone()),
+                Some((rt.name.clone(), rt.version.clone())),
             );
         }
 
@@ -166,31 +166,31 @@ pub fn serve_http(
 
                 Ok(Response::from_parts(parts, body))
             }),
-            Some(rt.name.clone()),
+            Some((rt.name.clone(), rt.version.clone())),
         )
     } else {
         future_response(
             Response::builder()
                 .status(StatusCode::SERVICE_UNAVAILABLE)
                 .body(Body::empty())
                 .unwrap(),
-            Some(rt.name.clone()),
+            Some((rt.name.clone(), rt.version.clone())),
         )
     }
 }
 
-fn future_response(res: Response<Body>, name: Option<String>) -> BoxedResponseFuture {
-    wrap_future(future::ok(res), name)
+fn future_response(res: Response<Body>, namever: Option<(String, String)>) -> BoxedResponseFuture {
+    wrap_future(future::ok(res), namever)
 }
 
-fn wrap_future<F>(fut: F, maybe_name: Option<String>) -> BoxedResponseFuture
+fn wrap_future<F>(fut: F, namever: Option<(String, String)>) -> BoxedResponseFuture
 where
     F: Future<Item = Response<Body>, Error = futures::Canceled> + Send + 'static,
 {
     Box::new(fut.and_then(move |res| {
-        let rt_name = maybe_name.unwrap_or(String::new());
+        let (name, ver) = namever.unwrap_or((String::new(), String::new()));
         metrics::HTTP_RESPONSE_COUNTER
-            .with_label_values(&[rt_name.as_str(), res.status().as_str()])
+            .with_label_values(&[name.as_str(), ver.as_str(), res.status().as_str()])
             .inc();
         Ok(res)
     }))

src/http_server.rs

@@ -31,13 +31,13 @@ lazy_static! {
     pub static ref HTTP_RESPONSE_COUNTER: IntCounterVec = register_int_counter_vec!(
         "fly_http_responses_total",
         "Total number of HTTP responses made.",
-        &["runtime", "status"]
+        &["runtime", "version", "status"]
     )
     .unwrap();
     pub static ref HTTP_RESPONSE_TIME_HISTOGRAM: HistogramVec = register_histogram_vec!(
         "fly_http_response_time_histogram_seconds",
         "HTTP response times by runtime, in seconds.",
-        &["runtime"],
+        &["runtime", "version"],
         vec![0.005, 0.01, 0.025, 0.05, 0.075, 0.1, 0.25, 0.5, 1.0, 5.0, 10.0, 60.0]
     )
     .unwrap();