From b879d62df3a047b34339cd9f4c41ddbdb47487ae Mon Sep 17 00:00:00 2001 From: yosuke ota <otameshiyo23@gmail.com> Date: Tue, 20 Jul 2021 12:52:09 +0900 Subject: [PATCH] Add valid-compile rule to recommended config --- README.md | 2 +- docs/rules/README.md | 2 +- docs/rules/valid-compile.md | 2 ++ src/configs/recommended.ts | 1 + src/rules/valid-compile.ts | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 9c5940dd1..39f8c155f 100644 --- a/README.md +++ b/README.md @@ -250,7 +250,7 @@ These rules relate to possible syntax or logic errors in Svelte code: | [@ota-meshi/svelte/no-dupe-else-if-blocks](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-dupe-else-if-blocks.html) | disallow duplicate conditions in `{#if}` / `{:else if}` chains | :star: | | [@ota-meshi/svelte/no-not-function-handler](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-not-function-handler.html) | disallow use of not function in event handler | :star: | | [@ota-meshi/svelte/no-object-in-text-mustaches](https://ota-meshi.github.io/eslint-plugin-svelte/rules/no-object-in-text-mustaches.html) | disallow objects in text mustache interpolation | :star: | -| [@ota-meshi/svelte/valid-compile](https://ota-meshi.github.io/eslint-plugin-svelte/rules/valid-compile.html) | disallow warnings when compiling. | | +| [@ota-meshi/svelte/valid-compile](https://ota-meshi.github.io/eslint-plugin-svelte/rules/valid-compile.html) | disallow warnings when compiling. | :star: | ## Security Vulnerability diff --git a/docs/rules/README.md b/docs/rules/README.md index 52676bb44..7bf67423b 100644 --- a/docs/rules/README.md +++ b/docs/rules/README.md @@ -18,7 +18,7 @@ These rules relate to possible syntax or logic errors in Svelte code: | [@ota-meshi/svelte/no-dupe-else-if-blocks](./no-dupe-else-if-blocks.md) | disallow duplicate conditions in `{#if}` / `{:else if}` chains | :star: | | [@ota-meshi/svelte/no-not-function-handler](./no-not-function-handler.md) | disallow use of not function in event handler | :star: | | [@ota-meshi/svelte/no-object-in-text-mustaches](./no-object-in-text-mustaches.md) | disallow objects in text mustache interpolation | :star: | -| [@ota-meshi/svelte/valid-compile](./valid-compile.md) | disallow warnings when compiling. | | +| [@ota-meshi/svelte/valid-compile](./valid-compile.md) | disallow warnings when compiling. | :star: | ## Security Vulnerability diff --git a/docs/rules/valid-compile.md b/docs/rules/valid-compile.md index 2b9322e76..b403a908b 100644 --- a/docs/rules/valid-compile.md +++ b/docs/rules/valid-compile.md @@ -10,6 +10,8 @@ since: "v0.7.0" > disallow warnings when compiling. +- :gear: This rule is included in `"plugin:@ota-meshi/svelte/recommended"`. + ## :book: Rule Details This rule uses Svelte compiler to check the source code. diff --git a/src/configs/recommended.ts b/src/configs/recommended.ts index f466ee787..c4db9c76e 100644 --- a/src/configs/recommended.ts +++ b/src/configs/recommended.ts @@ -14,5 +14,6 @@ export = { "@ota-meshi/svelte/no-not-function-handler": "error", "@ota-meshi/svelte/no-object-in-text-mustaches": "error", "@ota-meshi/svelte/system": "error", + "@ota-meshi/svelte/valid-compile": "error", }, } diff --git a/src/rules/valid-compile.ts b/src/rules/valid-compile.ts index 15d4eea7f..a8dcdc1c1 100644 --- a/src/rules/valid-compile.ts +++ b/src/rules/valid-compile.ts @@ -65,7 +65,7 @@ export default createRule("valid-compile", { docs: { description: "disallow warnings when compiling.", category: "Possible Errors", - recommended: false, + recommended: true, }, schema: [ {