Skip to content

Commit 7dff79b

Browse files
authored
[fix] externalize middlewares.js when using adapter-node's entryPoint (#2482)
1 parent 4c47afb commit 7dff79b

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.changeset/mighty-ears-divide.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/adapter-node': patch
3+
---
4+
5+
[fix] Correctly treat `middlewares.js` as external when using `entryPoint` option

packages/adapter-node/index.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
statSync,
88
writeFileSync
99
} from 'fs';
10-
import { join } from 'path';
10+
import { join, resolve } from 'path';
1111
import { pipeline } from 'stream';
1212
import glob from 'tiny-glob';
1313
import { fileURLToPath } from 'url';
@@ -81,7 +81,6 @@ export default function ({
8181
entryPoints: [entryPoint],
8282
outfile: join(out, 'index.js'),
8383
bundle: true,
84-
external: ['./middlewares.js'], // does not work, eslint does not exclude middlewares from target
8584
format: 'esm',
8685
platform: 'node',
8786
target: 'node12',
@@ -90,8 +89,12 @@ export default function ({
9089
{
9190
name: 'fix-middlewares-exclude',
9291
setup(build) {
93-
// Match an import called "./middlewares.js" and mark it as external
94-
build.onResolve({ filter: /^\.\/middlewares\.js$/ }, () => ({ external: true }));
92+
// Match an import of "middlewares.js" and mark it as external
93+
build.onResolve({ filter: /\/middlewares\.js$/ }, ({ path, resolveDir }) => {
94+
if (resolve(resolveDir, path) === resolve(out, 'middlewares.js')) {
95+
return { path: './middlewares.js', external: true };
96+
}
97+
});
9598
}
9699
}
97100
]

0 commit comments

Comments
 (0)