[fix] load function should not leak props (#2356)

Author: rmunn

.changeset/polite-elephants-care.md

@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+[fix] load function should not leak props to other components

packages/kit/src/runtime/client/renderer.js

@@ -404,7 +404,7 @@ export class Renderer {
 
 		for (let i = 0; i < filtered.length; i += 1) {
 			const loaded = filtered[i].loaded;
-			if (loaded) result.props[`props_${i}`] = await loaded.props;
+			result.props[`props_${i}`] = loaded ? await loaded.props : null;
 		}
 
 		if (

packages/kit/test/apps/basics/src/routes/load/_tests.js

@@ -231,4 +231,12 @@ export default function (test, is_dev) {
 		assert.equal(await page.innerHTML('.parsed'), '{"oddly":{"formatted":"json"}}');
 		assert.equal(await page.innerHTML('.raw'), '{ "oddly" : { "formatted" : "json" } }');
 	});
+
+	test('does not leak props to other pages', '/load/props/about', async ({ page, clicknav }) => {
+		assert.equal(await page.textContent('p'), 'Data: undefined');
+		await clicknav('[href="/load/props/"]');
+		assert.equal(await page.textContent('p'), 'Data: Hello from Index!');
+		await clicknav('[href="/load/props/about"]');
+		assert.equal(await page.textContent('p'), 'Data: undefined');
+	});
 }

packages/kit/test/apps/basics/src/routes/load/props/__layout.svelte

@@ -0,0 +1,10 @@
+<header>
+	<nav>
+		<a href="/load/props/">Index</a>
+		<a href="/load/props/about">About</a>
+	</nav>
+</header>
+
+<main>
+	<slot />
+</main>

packages/kit/test/apps/basics/src/routes/load/props/about.svelte

@@ -0,0 +1,7 @@
+<script>
+	export let data = 'undefined';
+</script>
+
+<h3>About</h3>
+
+<p>Data: {data}</p>

packages/kit/test/apps/basics/src/routes/load/props/index.svelte

@@ -0,0 +1,14 @@
+<script context="module">
+	export async function load() {
+		const data = 'Hello from Index!';
+		return { props: { data } };
+	}
+</script>
+
+<script>
+	export let data = 'undefined';
+</script>
+
+<h3>Index</h3>
+
+<p>Data: {data}</p>