Skip to content

Commit ea63518

Browse files
GrygrFlzrGrygrFlzr
authored
Make tests less flaky (#501)
kit: update most basics routes test to wait for navigation on click
1 parent a4c4d46 commit ea63518

File tree

5 files changed

+29
-19
lines changed

5 files changed

+29
-19
lines changed

‎packages/kit/test/apps/basics/src/routes/accessibility/__tests__.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import * as assert from 'uvu/assert';
44
export default function (test) {
55
// TODO unskip this
66
test.skip('resets focus', '/accessibility/a', async ({ page }) => {
7-
await page.click('[href="/accessibility/b"]');
7+
await Promise.all([page.waitForNavigation(), page.click('[href="/accessibility/b"]')]);
88
await page.waitForTimeout(50);
99
assert.equal(await page.innerHTML('h1'), 'b');
1010
await page.waitForTimeout(50);
@@ -14,7 +14,7 @@ export default function (test) {
1414
assert.equal(await page.evaluate(() => document.activeElement.nodeName), 'A');
1515
assert.equal(await page.evaluate(() => document.activeElement.textContent), 'a');
1616

17-
await page.click('[href="/accessibility/a"]');
17+
await Promise.all([page.waitForNavigation(), page.click('[href="/accessibility/a"]')]);
1818
await page.waitForTimeout(50);
1919
assert.equal(await page.innerHTML('h1'), 'a');
2020
assert.equal(await page.evaluate(() => document.activeElement.nodeName), 'BODY');
@@ -33,7 +33,7 @@ export default function (test) {
3333
// live region should exist, but be empty
3434
assert.equal(await page.innerHTML('[aria-live]'), '');
3535

36-
await page.click('[href="/accessibility/b"]');
36+
await Promise.all([page.waitForNavigation(), page.click('[href="/accessibility/b"]')]);
3737
await page.waitForTimeout(50);
3838
assert.equal(await page.innerHTML('[aria-live]'), 'Navigated to b'); // TODO i18n
3939
} else {

‎packages/kit/test/apps/basics/src/routes/preload/__tests__.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as assert from 'uvu/assert';
33
/** @type {import('../../../../../types').TestMaker} */
44
export default function test(test) {
55
test('errors on preload', '/preload', async ({ page }) => {
6-
await page.click('[href="/preload/uses-preload"]');
6+
await Promise.all([page.waitForNavigation(), page.click('[href="/preload/uses-preload"]')]);
77

88
assert.equal(await page.textContent('h1'), '500');
99
assert.equal(await page.textContent('footer'), 'Custom layout');

‎packages/kit/test/apps/basics/src/routes/redirect/__tests__.js‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import * as assert from 'uvu/assert';
33
/** @type {import('../../../../../types').TestMaker} */
44
export default function (test, is_dev) {
55
test('redirect', '/redirect', async ({ base, page, js }) => {
6-
await page.click('[href="/redirect/a"]');
6+
await Promise.all([page.waitForNavigation(), page.click('[href="/redirect/a"]')]);
77

88
if (js) await page.waitForTimeout(50);
99

@@ -30,7 +30,10 @@ export default function (test, is_dev) {
3030
});
3131

3232
test('errors on missing status', '/redirect', async ({ base, page, js }) => {
33-
await page.click('[href="/redirect/missing-status/a"]');
33+
await Promise.all([
34+
page.waitForNavigation(),
35+
page.click('[href="/redirect/missing-status/a"]')
36+
]);
3437

3538
if (js) await page.waitForTimeout(50);
3639

@@ -43,7 +46,10 @@ export default function (test, is_dev) {
4346
});
4447

4548
test('errors on invalid status', '/redirect', async ({ base, page, js }) => {
46-
await page.click('[href="/redirect/missing-status/b"]');
49+
await Promise.all([
50+
page.waitForNavigation(),
51+
page.click('[href="/redirect/missing-status/b"]')
52+
]);
4753

4854
if (js) await page.waitForTimeout(50);
4955

‎packages/kit/test/apps/basics/src/routes/routing/__tests__.js‎

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default function (test) {
66
'redirects from /routing/ to /routing',
77
'/routing/slashes',
88
async ({ base, page, app, js }) => {
9-
await page.click('a[href="/routing/"]');
9+
await Promise.all([page.waitForNavigation(), page.click('a[href="/routing/"]')]);
1010
assert.equal(await page.url(), `${base}/routing`);
1111
assert.equal(await page.textContent('h1'), 'Great success!');
1212

@@ -24,7 +24,7 @@ export default function (test) {
2424
'redirects from /routing/? to /routing',
2525
'/routing/slashes',
2626
async ({ base, page, app, js }) => {
27-
await page.click('a[href="/routing/?"]');
27+
await Promise.all([page.waitForNavigation(), page.click('a[href="/routing/?"]')]);
2828
assert.equal(await page.url(), `${base}/routing`);
2929
assert.equal(await page.textContent('h1'), 'Great success!');
3030

@@ -42,7 +42,7 @@ export default function (test) {
4242
'redirects from /routing/?foo=bar to /routing?foo=bar',
4343
'/routing/slashes',
4444
async ({ base, page, app, js }) => {
45-
await page.click('a[href="/routing/?foo=bar"]');
45+
await Promise.all([page.waitForNavigation(), page.click('a[href="/routing/?foo=bar"]')]);
4646
assert.equal(await page.url(), `${base}/routing?foo=bar`);
4747
assert.equal(await page.textContent('h1'), 'Great success!');
4848

@@ -97,7 +97,7 @@ export default function (test) {
9797
await page.waitForTimeout(500);
9898

9999
const requests = await capture_requests(async () => {
100-
await page.click('a[href="/routing/a"]');
100+
await Promise.all([page.waitForNavigation(), page.click('a[href="/routing/a"]')]);
101101

102102
await page.waitForFunction(() => document.location.pathname == '/routing/a');
103103

@@ -126,7 +126,10 @@ export default function (test) {
126126
});
127127

128128
test('does not attempt client-side navigation to server routes', '/routing', async ({ page }) => {
129-
await page.click('[href="/routing/ambiguous/ok.json"]');
129+
await Promise.all([
130+
page.waitForNavigation(),
131+
page.click('[href="/routing/ambiguous/ok.json"]')
132+
]);
130133
await page.waitForFunction(() => document.location.pathname == '/routing/ambiguous/ok.json');
131134

132135
assert.equal(await page.textContent('body'), 'ok');
@@ -137,13 +140,13 @@ export default function (test) {
137140
});
138141

139142
test('resets the active element after navigation', '/routing', async ({ page }) => {
140-
await page.click('[href="/routing/a"]');
143+
await Promise.all([page.waitForNavigation(), page.click('[href="/routing/a"]')]);
141144
await page.waitForFunction(() => document.activeElement.nodeName == 'BODY');
142145
});
143146

144147
test('navigates between routes with empty parts', '/routing/dirs/foo', async ({ page }) => {
145148
assert.equal(await page.textContent('h1'), 'foo');
146-
await page.click('[href="bar"]');
149+
await Promise.all([page.waitForNavigation(), page.click('[href="bar"]')]);
147150
await page.waitForSelector('.bar');
148151

149152
assert.equal(await page.textContent('h1'), 'bar');
@@ -182,25 +185,25 @@ export default function (test) {
182185
async ({ page }) => {
183186
assert.equal(await page.textContent('h1'), 'A page');
184187

185-
await page.click('[href="/routing/dirs/foo/xyz"]');
188+
await Promise.all([page.waitForNavigation(), page.click('[href="/routing/dirs/foo/xyz"]')]);
186189
assert.equal(await page.textContent('h1'), 'B page');
187190
}
188191
);
189192

190193
test('find regexp routes', '/routing/qwe', async ({ page }) => {
191194
assert.equal(await page.textContent('h1'), 'qwe');
192195

193-
await page.click('[href="234"]');
196+
await Promise.all([page.waitForNavigation(), page.click('[href="234"]')]);
194197
assert.equal(await page.textContent('h1'), 'Regexp page 234');
195198

196-
await page.click('[href="regexp/234"]');
199+
await Promise.all([page.waitForNavigation(), page.click('[href="regexp/234"]')]);
197200
assert.equal(await page.textContent('h1'), 'Nested regexp page 234');
198201
});
199202

200203
test('invalidates page when a segment is skipped', '/routing/skipped/x/1', async ({ page }) => {
201204
assert.equal(await page.textContent('h1'), 'x/1');
202205

203-
await page.click('#goto-y1');
206+
await Promise.all([page.waitForNavigation(), page.click('#goto-y1')]);
204207
assert.equal(await page.textContent('h1'), 'y/1');
205208
});
206209
}

‎packages/kit/test/apps/basics/src/routes/store/__tests__.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import * as assert from 'uvu/assert';
33
/** @type {import('../../../../../types').TestMaker} */
44
export default function (test) {
55
test('page store functions as expected', '/store', async ({ page, js }) => {
6+
await page.waitForLoadState();
67
assert.equal(await page.textContent('h1'), 'Test');
78
assert.equal(await page.textContent('h2'), 'Calls: 1');
89

@@ -18,7 +19,7 @@ export default function (test) {
1819
assert.equal(await page.textContent('#navigating'), 'not currently navigating');
1920

2021
if (js) {
21-
await page.click('a[href="/store/navigating/b"]');
22+
await Promise.all([page.waitForNavigation(), page.click('a[href="/store/navigating/b"]')]);
2223

2324
assert.equal(
2425
await page.textContent('#navigating'),

0 commit comments

Comments
 (0)