You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The dots here are not literals as they have not been escaped, they represent "any character".
For example, any file with a specxmjs extension would match.
On Windows, test/index.mjs does not correctly locate integration tests. I can see on the github CI it at least works with the Linux system, though.
To Reproduce pnpm test on a Windows system
Expected behavior
Run all tests.
Severity
Since the CI currently runs Linux anyway, core tests won't be missed, but as Windows-related contributions get added and access to the Windows CI becomes available, this will lead to tests being skipped and falsely reporting success on Windows.
Will submit as a PR. Let me know if I'm missing something obvious with this change. Other than the fact it looks really ugly because we have to escape the pattern escapes to be valid JSON.
The text was updated successfully, but these errors were encountered:
Describe the bug
Currently, the test pattern used is as follows:
kit/packages/kit/package.json
Line 53 in d9fc240
There are two issues:
For example, any file with a
specxmjs
extension would match.test/index.mjs
does not correctly locate integration tests. I can see on the github CI it at least works with the Linux system, though.To Reproduce
pnpm test
on a Windows systemExpected behavior
Run all tests.
Severity
Since the CI currently runs Linux anyway, core tests won't be missed, but as Windows-related contributions get added and access to the Windows CI becomes available, this will lead to tests being skipped and falsely reporting success on Windows.
Solution
Will submit as a PR. Let me know if I'm missing something obvious with this change. Other than the fact it looks really ugly because we have to escape the pattern escapes to be valid JSON.
The text was updated successfully, but these errors were encountered: