Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Preload all Route assets #70

Closed
lukeed opened this issue Jan 6, 2018 · 3 comments · Fixed by #1269
Closed

Preload all Route assets #70

lukeed opened this issue Jan 6, 2018 · 3 comments · Fixed by #1269

Comments

@lukeed
Copy link
Member

lukeed commented Jan 6, 2018

Taken from: https://github.com/sveltejs/sapper/blob/master/lib/index.js#L148

At the very least, styles should be preloaded via the server. I'd argue that fonts & co should be set as a <link rel=preload/> by the user from within the template... but the server should send down the bare minimum assets.

@antony
Copy link
Member

antony commented Jun 16, 2020

@lukeed the original code for this is gone, so it's difficult to understand the issue.

Was the goal that things like styles and client js should have a rel="preload" attribute? Somebody was suggesting this the other day in chat.

@lukeed
Copy link
Member Author

lukeed commented Jun 16, 2020

Yup. Fail on my part for linking to master

@benmccann
Copy link
Member

benmccann commented Jun 16, 2020

This sounds like a duplicate of #408

I actually have a PR pending #1269 that will preload the JS and CSS, which has been pretty impactful in my testing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants