Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

sapper-noscroll attribute is ignored #969

Closed
felideon opened this issue Oct 29, 2019 · 1 comment
Closed

sapper-noscroll attribute is ignored #969

felideon opened this issue Oct 29, 2019 · 1 comment
Labels

Comments

@felideon
Copy link

Describe the bug
Sapper scrolls to the top even when adding the sapper-noscroll attribute.

To Reproduce
Add a link from one route to another using the sapper-noscroll attribute.

Expected behavior
Adding the sapper-noscroll attribute to an <a> element should prevent the page from being scrolled to the top, as per #376. It should be reproducible from a vanilla copy of sapper-template, except the pages aren't very long and scroll position might not be obvious.

Information about your Sapper Installation:

  • Browser: Chrome 78.0.3904.70, Safari 13.0.3

  • OS: macOS Mojave 10.14.6

  • Environment: local

  • Sapper version: 0.27.9

  • Svelte version: 3.12.1

  • If it is an exported (npm run export) or dynamic application: both

  • Whether your application uses Webpack or Rollup: Rollup

Severity
Somewhat annoying, specially since this is a nice feature to have! Also it is preventing me from doing my own Element.scrollIntoView() as Sapper's scroll to top seems to win.

@pngwn pngwn added the bug label Nov 19, 2019
@felideon
Copy link
Author

Hmm, no longer reproducible with Svelte 3.16.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants