ignore rules rather than adding catch blocks. add async to functions returning promises

Author: benmccann

eslint.config.js

@@ -17,6 +17,8 @@ export default [
 			'@typescript-eslint/await-thenable': 'error',
 			'@typescript-eslint/no-floating-promises': 'error',
 			'@typescript-eslint/no-misused-promises': 'error',
+			'@typescript-eslint/prefer-promise-reject-errors': 'error',
+			'@typescript-eslint/promise-function-async': 'error',
 			'@typescript-eslint/require-await': 'error',
 			'no-console': 'error',
 			'lube/svelte-naming-convention': ['error', { fixSameNames: true }],

packages/svelte/src/compiler/preprocess/replace_in_code.js

@@ -20,7 +20,7 @@ export function slice_source(code_slice, offset, { file_basename, filename, get_
  * @param {(...match: any[]) => Promise<MappedCode>} get_replacement
  * @param {string} source
  */
-function calculate_replacements(re, get_replacement, source) {
+async function calculate_replacements(re, get_replacement, source) {
 	/**
 	 * @type {Array<Promise<import('./private.js').Replacement>>}
 	 */

packages/svelte/src/internal/client/dom/elements/custom-element.js

@@ -193,18 +193,14 @@ if (typeof HTMLElement === 'function') {
 		disconnectedCallback() {
 			this.$$cn = false;
 			// In a microtask, because this could be a move within the DOM
-			Promise.resolve()
-				.then(() => {
-					if (!this.$$cn && this.$$c) {
-						this.$$c.$destroy();
-						destroy_effect(this.$$me);
-						this.$$c = undefined;
-					}
-				})
-				.catch((err) => {
-					// eslint-disable-next-line no-console
-					console.error(err);
-				});
+			// eslint-disable-next-line @typescript-eslint/no-floating-promises
+			Promise.resolve().then(() => {
+				if (!this.$$cn && this.$$c) {
+					this.$$c.$destroy();
+					destroy_effect(this.$$me);
+					this.$$c = undefined;
+				}
+			});
 		}
 
 		/**

packages/svelte/src/internal/client/dom/elements/misc.js

@@ -42,19 +42,15 @@ export function add_form_reset_listener() {
 			(evt) => {
 				// Needs to happen one tick later or else the dom properties of the form
 				// elements have not updated to their reset values yet
-				Promise.resolve()
-					.then(() => {
-						if (!evt.defaultPrevented) {
-							for (const e of /**@type {HTMLFormElement} */ (evt.target).elements) {
-								// @ts-expect-error
-								e.__on_r?.();
-							}
+				// eslint-disable-next-line @typescript-eslint/no-floating-promises
+				Promise.resolve().then(() => {
+					if (!evt.defaultPrevented) {
+						for (const e of /**@type {HTMLFormElement} */ (evt.target).elements) {
+							// @ts-expect-error
+							e.__on_r?.();
 						}
-					})
-					.catch((err) => {
-						// eslint-disable-next-line no-console
-						console.error(err);
-					});
+					}
+				});
 			},
 			// In the capture phase to guarantee we get noticed of it (no possiblity of stopPropagation)
 			{ capture: true }

packages/svelte/src/motion/spring.js

@@ -77,7 +77,7 @@ export function spring(value, opts = {}) {
 	 * @param {import('./private').SpringUpdateOpts} opts
 	 * @returns {Promise<void>}
 	 */
-	function set(new_value, opts = {}) {
+	async function set(new_value, opts = {}) {
 		target_value = new_value;
 		const token = (current_token = {});
 		if (value == null || opts.hard || (spring.stiffness >= 1 && spring.damping >= 1)) {
@@ -120,20 +120,17 @@ export function spring(value, opts = {}) {
 			});
 		}
 		return new Promise((fulfil) => {
-			/** @type {import('../internal/client/types').Task} */ (task).promise
-				.then(() => {
-					if (token === current_token) fulfil();
-				})
-				.catch((err) => {
-					// eslint-disable-next-line no-console
-					console.error(err);
-				});
+			// eslint-disable-next-line @typescript-eslint/no-floating-promises
+			/** @type {import('../internal/client/types').Task} */ (task).promise.then(() => {
+				if (token === current_token) fulfil();
+			});
 		});
 	}
 	/** @type {import('./public.js').Spring<T>} */
 	const spring = {
 		set,
-		update: (fn, opts) => set(fn(/** @type {T} */ (target_value), /** @type {T} */ (value)), opts),
+		update: async (fn, opts) =>
+			set(fn(/** @type {T} */ (target_value), /** @type {T} */ (value)), opts),
 		subscribe: store.subscribe,
 		stiffness,
 		damping,

packages/svelte/src/motion/tweened.js

@@ -88,7 +88,7 @@ export function tweened(value, defaults = {}) {
 	 * @param {T} new_value
 	 * @param {import('./private').TweenedOptions<T>} [opts]
 	 */
-	function set(new_value, opts) {
+	async function set(new_value, opts) {
 		target_value = new_value;
 
 		if (value == null) {
@@ -145,7 +145,7 @@ export function tweened(value, defaults = {}) {
 	}
 	return {
 		set,
-		update: (fn, opts) =>
+		update: async (fn, opts) =>
 			set(fn(/** @type {any} */ (target_value), /** @type {any} */ (value)), opts),
 		subscribe: store.subscribe
 	};