render tag + slot could occur in legacy mode as well, error there, too

Author: dummdidumm

packages/svelte/src/compiler/phases/2-analyze/index.js

@@ -456,10 +456,6 @@ export function analyze_component(root, source, options) {
 				}
 			}
 		}
-
-		if (analysis.uses_render_tags && (analysis.uses_slots || analysis.slot_names.size > 0)) {
-			error(analysis.slot_names.values().next().value, 'conflicting-slot-usage');
-		}
 	} else {
 		instance.scope.declare(b.id('$$props'), 'bindable_prop', 'synthetic');
 		instance.scope.declare(b.id('$$restProps'), 'rest_prop', 'synthetic');
@@ -507,6 +503,10 @@ export function analyze_component(root, source, options) {
 		analysis.reactive_statements = order_reactive_statements(analysis.reactive_statements);
 	}
 
+	if (analysis.uses_render_tags && (analysis.uses_slots || analysis.slot_names.size > 0)) {
+		error(analysis.slot_names.values().next().value, 'conflicting-slot-usage');
+	}
+
 	// warn on any nonstate declarations that are a) reassigned and b) referenced in the template
 	for (const scope of [module.scope, instance.scope]) {
 		outer: for (const [name, binding] of scope.declarations) {

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -578,6 +578,8 @@ const validation = {
 		});
 	},
 	RenderTag(node, context) {
+		context.state.analysis.uses_render_tags = true;
+
 		const raw_args = unwrap_optional(node.expression).arguments;
 		for (const arg of raw_args) {
 			if (arg.type === 'SpreadElement') {
@@ -1195,9 +1197,6 @@ export const validation_runes = merge(validation, a11y_validators, {
 			warn(state.analysis.warnings, node, path, 'deprecated-event-handler', node.name);
 		}
 	},
-	RenderTag(_, { state }) {
-		state.analysis.uses_render_tags = true;
-	},
 	// TODO this is a code smell. need to refactor this stuff
 	ClassBody: validation_runes_js.ClassBody,
 	ClassDeclaration: validation_runes_js.ClassDeclaration,