remove old validation

Author: dummdidumm

packages/svelte/src/compiler/phases/3-transform/client/visitors/AssignmentExpression.js

@@ -7,7 +7,7 @@ import {
 	get_attribute_expression,
 	is_event_attribute
 } from '../../../../utils/ast.js';
-import { dev, is_ignored, locate_node } from '../../../../state.js';
+import { dev, locate_node } from '../../../../state.js';
 import { should_proxy } from '../utils.js';
 import { visit_assignment_expression } from '../../shared/assignments.js';
 
@@ -16,13 +16,9 @@ import { visit_assignment_expression } from '../../shared/assignments.js';
  * @param {Context} context
  */
 export function AssignmentExpression(node, context) {
-	const expression = /** @type {Expression} */ (
+	return /** @type {Expression} */ (
 		visit_assignment_expression(node, context, build_assignment) ?? context.next()
 	);
-
-	return is_ignored(node, 'ownership_invalid_mutation')
-		? b.call('$.skip_ownership_validation', b.thunk(expression))
-		: expression;
 }
 
 /**

packages/svelte/src/compiler/phases/3-transform/client/visitors/ClassBody.js

@@ -161,33 +161,6 @@ export function ClassBody(node, context) {
 		body.push(/** @type {MethodDefinition} **/ (context.visit(definition, child_state)));
 	}
 
-	if (dev && public_state.size > 0) {
-		// add an `[$.ADD_OWNER]` method so that a class with state fields can widen ownership
-		body.push(
-			b.method(
-				'method',
-				b.id('$.ADD_OWNER'),
-				[b.id('owner')],
-				[
-					b.stmt(
-						b.call(
-							'$.add_owner_to_class',
-							b.this,
-							b.id('owner'),
-							b.array(
-								Array.from(public_state).map(([name]) =>
-									b.thunk(b.call('$.get', b.member(b.this, b.private_id(name))))
-								)
-							),
-							is_ignored(node, 'ownership_invalid_binding') && b.true
-						)
-					)
-				],
-				true
-			)
-		);
-	}
-
 	return { ...node, body };
 }
 

packages/svelte/src/compiler/phases/3-transform/client/visitors/UpdateExpression.js

@@ -1,6 +1,5 @@
 /** @import { AssignmentExpression, Expression, UpdateExpression } from 'estree' */
 /** @import { Context } from '../types' */
-import { is_ignored } from '../../../../state.js';
 import { object } from '../../../../utils/ast.js';
 import * as b from '../../../../utils/builders.js';
 
@@ -51,7 +50,5 @@ export function UpdateExpression(node, context) {
 		);
 	}
 
-	return is_ignored(node, 'ownership_invalid_mutation')
-		? b.call('$.skip_ownership_validation', b.thunk(update))
-		: update;
+	return update;
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/component.js

@@ -178,22 +178,6 @@ export function build_component(node, component_name, context, anchor = context.
 			}
 		} else if (attribute.type === 'BindDirective') {
 			const expression = /** @type {Expression} */ (context.visit(attribute.expression));
-
-			if (dev && attribute.name !== 'this') {
-				binding_initializers.push(
-					b.stmt(
-						b.call(
-							b.id('$.add_owner_effect'),
-							expression.type === 'SequenceExpression'
-								? expression.expressions[0]
-								: b.thunk(expression),
-							b.id(component_name),
-							is_ignored(node, 'ownership_invalid_binding') && b.true
-						)
-					)
-				);
-			}
-
 			if (expression.type === 'SequenceExpression') {
 				if (attribute.name === 'this') {
 					bind_this = attribute.expression;

packages/svelte/src/internal/client/constants.js

@@ -23,6 +23,5 @@ export const EFFECT_HAS_DERIVED = 1 << 20;
 export const EFFECT_IS_UPDATING = 1 << 21;
 
 export const STATE_SYMBOL = Symbol('$state');
-export const STATE_SYMBOL_METADATA = Symbol('$state metadata');
 export const LEGACY_PROPS = Symbol('legacy props');
 export const LOADING_ATTR_SYMBOL = Symbol('');

packages/svelte/src/internal/client/context.js

@@ -1,7 +1,6 @@
 /** @import { ComponentContext } from '#client' */
 
 import { DEV } from 'esm-env';
-import { add_owner } from './dev/ownership.js';
 import { lifecycle_outside_component } from '../shared/errors.js';
 import { source } from './reactivity/sources.js';
 import {
@@ -67,15 +66,6 @@ export function getContext(key) {
  */
 export function setContext(key, context) {
 	const context_map = get_or_init_context_map('setContext');
-
-	if (DEV) {
-		// When state is put into context, we treat as if it's global from now on.
-		// We do for performance reasons (it's for example very expensive to call
-		// getContext on a big object many times when part of a list component)
-		// and danger of false positives.
-		untrack(() => add_owner(context, null, true));
-	}
-
 	context_map.set(key, context);
 	return context;
 }

packages/svelte/src/internal/client/dev/ownership.js

@@ -1,13 +1,5 @@
-/** @import { ProxyMetadata } from '#client' */
 /** @typedef {{ file: string, line: number, column: number }} Location */
 
-import { STATE_SYMBOL_METADATA } from '../constants.js';
-import { render_effect, user_pre_effect } from '../reactivity/effects.js';
-import { dev_current_component_function } from '../context.js';
-import { get_prototype_of } from '../../shared/utils.js';
-import * as w from '../warnings.js';
-import { FILENAME, UNINITIALIZED } from '../../../constants.js';
-
 /** @type {Record<string, Array<{ start: Location, end: Location, component: Function }>>} */
 const boundaries = {};
 
@@ -71,8 +63,6 @@ export function get_component() {
 	return null;
 }
 
-export const ADD_OWNER = Symbol('ADD_OWNER');
-
 /**
  * Together with `mark_module_end`, this function establishes the boundaries of a `.svelte` file,
  * such that subsequent calls to `get_component` can tell us which component is responsible
@@ -106,199 +96,3 @@ export function mark_module_end(component) {
 		boundary.component = component;
 	}
 }
-
-/**
- * @param {any} object
- * @param {any | null} owner
- * @param {boolean} [global]
- * @param {boolean} [skip_warning]
- */
-export function add_owner(object, owner, global = false, skip_warning = false) {
-	if (object && !global) {
-		const component = dev_current_component_function;
-		const metadata = object[STATE_SYMBOL_METADATA];
-		if (metadata && !has_owner(metadata, component)) {
-			let original = get_owner(metadata);
-
-			if (owner && owner[FILENAME] !== component[FILENAME] && !skip_warning) {
-				w.ownership_invalid_binding(component[FILENAME], owner[FILENAME], original[FILENAME]);
-			}
-		}
-	}
-
-	add_owner_to_object(object, owner, new Set());
-}
-
-/**
- * @param {() => unknown} get_object
- * @param {any} Component
- * @param {boolean} [skip_warning]
- */
-export function add_owner_effect(get_object, Component, skip_warning = false) {
-	user_pre_effect(() => {
-		add_owner(get_object(), Component, false, skip_warning);
-	});
-}
-
-/**
- * @param {any} _this
- * @param {Function} owner
- * @param {Array<() => any>} getters
- * @param {boolean} skip_warning
- */
-export function add_owner_to_class(_this, owner, getters, skip_warning) {
-	_this[ADD_OWNER].current ||= getters.map(() => UNINITIALIZED);
-
-	for (let i = 0; i < getters.length; i += 1) {
-		const current = getters[i]();
-		// For performance reasons we only re-add the owner if the state has changed
-		if (current !== _this[ADD_OWNER][i]) {
-			_this[ADD_OWNER].current[i] = current;
-			add_owner(current, owner, false, skip_warning);
-		}
-	}
-}
-
-/**
- * @param {ProxyMetadata | null} from
- * @param {ProxyMetadata} to
- */
-export function widen_ownership(from, to) {
-	if (to.owners === null) {
-		return;
-	}
-
-	while (from) {
-		if (from.owners === null) {
-			to.owners = null;
-			break;
-		}
-
-		for (const owner of from.owners) {
-			to.owners.add(owner);
-		}
-
-		from = from.parent;
-	}
-}
-
-/**
- * @param {any} object
- * @param {Function | null} owner If `null`, then the object is globally owned and will not be checked
- * @param {Set<any>} seen
- */
-function add_owner_to_object(object, owner, seen) {
-	const metadata = /** @type {ProxyMetadata} */ (object?.[STATE_SYMBOL_METADATA]);
-
-	if (metadata) {
-		// this is a state proxy, add owner directly, if not globally shared
-		if ('owners' in metadata && metadata.owners != null) {
-			if (owner) {
-				metadata.owners.add(owner);
-			} else {
-				metadata.owners = null;
-			}
-		}
-	} else if (object && typeof object === 'object') {
-		if (seen.has(object)) return;
-		seen.add(object);
-		if (ADD_OWNER in object && object[ADD_OWNER]) {
-			// this is a class with state fields. we put this in a render effect
-			// so that if state is replaced (e.g. `instance.name = { first, last }`)
-			// the new state is also co-owned by the caller of `getContext`
-			render_effect(() => {
-				object[ADD_OWNER](owner);
-			});
-		} else {
-			var proto = get_prototype_of(object);
-
-			if (proto === Object.prototype) {
-				// recurse until we find a state proxy
-				for (const key in object) {
-					if (Object.getOwnPropertyDescriptor(object, key)?.get) {
-						// Similar to the class case; the getter could update with a new state
-						let current = UNINITIALIZED;
-						render_effect(() => {
-							const next = object[key];
-							if (current !== next) {
-								current = next;
-								add_owner_to_object(next, owner, seen);
-							}
-						});
-					} else {
-						add_owner_to_object(object[key], owner, seen);
-					}
-				}
-			} else if (proto === Array.prototype) {
-				// recurse until we find a state proxy
-				for (let i = 0; i < object.length; i += 1) {
-					add_owner_to_object(object[i], owner, seen);
-				}
-			}
-		}
-	}
-}
-
-/**
- * @param {ProxyMetadata} metadata
- * @param {Function} component
- * @returns {boolean}
- */
-function has_owner(metadata, component) {
-	if (metadata.owners === null) {
-		return true;
-	}
-
-	return (
-		metadata.owners.has(component) ||
-		// This helps avoid false positives when using HMR, where the component function is replaced
-		(FILENAME in component &&
-			[...metadata.owners].some(
-				(owner) => /** @type {any} */ (owner)[FILENAME] === component[FILENAME]
-			)) ||
-		(metadata.parent !== null && has_owner(metadata.parent, component))
-	);
-}
-
-/**
- * @param {ProxyMetadata} metadata
- * @returns {any}
- */
-function get_owner(metadata) {
-	return (
-		metadata?.owners?.values().next().value ??
-		get_owner(/** @type {ProxyMetadata} */ (metadata.parent))
-	);
-}
-
-let skip = false;
-
-/**
- * @param {() => any} fn
- */
-export function skip_ownership_validation(fn) {
-	skip = true;
-	fn();
-	skip = false;
-}
-
-/**
- * @param {ProxyMetadata} metadata
- */
-export function check_ownership(metadata) {
-	if (skip) return;
-
-	const component = get_component();
-
-	if (component && !has_owner(metadata, component)) {
-		let original = get_owner(metadata);
-
-		// @ts-expect-error
-		if (original[FILENAME] !== component[FILENAME]) {
-			// @ts-expect-error
-			w.ownership_invalid_mutation(component[FILENAME], original[FILENAME]);
-		} else {
-			w.ownership_invalid_mutation();
-		}
-	}
-}

packages/svelte/src/internal/client/index.js

@@ -4,15 +4,7 @@ export { assign, assign_and, assign_or, assign_nullish } from './dev/assign.js';
 export { cleanup_styles } from './dev/css.js';
 export { add_locations } from './dev/elements.js';
 export { hmr } from './dev/hmr.js';
-export {
-	ADD_OWNER,
-	add_owner,
-	mark_module_start,
-	mark_module_end,
-	add_owner_effect,
-	add_owner_to_class,
-	skip_ownership_validation
-} from './dev/ownership.js';
+export { mark_module_start, mark_module_end } from './dev/ownership.js';
 export { check_target, legacy_api } from './dev/legacy.js';
 export { trace } from './dev/tracing.js';
 export { inspect } from './dev/inspect.js';