address comments

Author: benmccann

src/runtime/internal/ssr.ts

@@ -76,27 +76,27 @@ const CONTENT_REGEX = /[&<]/g;
  * Note: this method is performance sensitive and has been optimized
  * https://github.com/sveltejs/svelte/pull/5701
  */
-export function escape(html: string, is_attr = false) {
-	if (typeof html !== 'string') return html;
+export function escape(value: unknown, is_attr = false) {
+	const str: string = typeof value === 'string' ? value : value.toString();
 
 	const pattern = is_attr ? ATTR_REGEX : CONTENT_REGEX;
 	pattern.lastIndex = 0;
 
 	let escaped = '';
 	let last = 0;
 
-  while (pattern.test(html)) {
-    const i = pattern.lastIndex - 1;
-    const ch = html[i];
-    escaped += html.substring(last, i) + (ch === '&' ? '&amp;' : (ch === '"' ? '&quot;' : '&lt;'));
-    last = i + 1;
-  }
+	while (pattern.test(str)) {
+		const i = pattern.lastIndex - 1;
+		const ch = str[i];
+		escaped += str.substring(last, i) + (ch === '&' ? '&amp;' : (ch === '"' ? '&quot;' : '&lt;'));
+		last = i + 1;
+	}
 
-	return escaped + html.substring(last);
+	return escaped + str.substring(last);
 }
 
 export function escape_attribute_value(value) {
-	return typeof value === 'string' ? escape(value, true) : value;
+	return escape(value, true);
 }
 
 export function escape_object(obj) {
@@ -192,7 +192,7 @@ export function create_ssr_component(fn) {
 
 export function add_attribute(name, value, boolean) {
 	if (value == null || (boolean && !value)) return '';
-	const assignment = (boolean && value === true) ? '' : `="${escape_attribute_value(value.toString())}"`;
+	const assignment = (boolean && value === true) ? '' : `="${escape_attribute_value(value)}"`;
 	return ` ${name}${assignment}`;
 }