Fixes binding-input-group-each-16 but introduces a failure in binding-input-group-each-12

Author: ciscoheat

packages/svelte/src/compiler/phases/2-analyze/index.js

@@ -1036,7 +1036,7 @@ const common_visitors = {
 		// If the same identifiers in the same order are used in another bind:group, they will be in the same group.
 		// (there's an edge case where `bind:group={a[i]}` will be in a different group than `bind:group={a[j]}` even when i == j,
 		//  but this is a limitation of the current static analysis we do; it also never worked in Svelte 4)
-		const bindings = expression_ids.map((id) => context.state.scope.get(id.name));
+		const bindings = expression_ids.map((id) => context.state.scope.get(id.name) ?? id);
 		let group_name;
 		outer: for (const [b, group] of context.state.analysis.binding_groups) {
 			if (b.length !== bindings.length) continue;

packages/svelte/src/compiler/phases/types.d.ts

@@ -68,7 +68,7 @@ export interface ComponentAnalysis extends Analysis {
 	inject_styles: boolean;
 	reactive_statements: Map<LabeledStatement, ReactiveStatement>;
 	/** Identifiers that make up the `bind:group` expression -> internal group binding name */
-	binding_groups: Map<Array<Binding | null>, Identifier>;
+	binding_groups: Map<Array<Binding | Identifier | null>, Identifier>;
 	slot_names: Set<string>;
 }
 

packages/svelte/src/compiler/utils/ast.js

@@ -108,11 +108,8 @@ export function extract_all_identifiers_from_expression(expr) {
 		expr,
 		{},
 		{
-			Identifier(node, { path }) {
-				const parent = path.at(-1);
-				if (parent?.type !== 'MemberExpression' || parent.property !== node || parent.computed) {
-					nodes.push(node);
-				}
+			Identifier(node) {
+				nodes.push(node);
 			}
 		}
 	);