From 3a104c41db9b6df5603de7b2625788fafe5e952b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20S=C3=B6derlund?= <ciscoheat@gmail.com>
Date: Fri, 2 Feb 2024 13:02:22 +0100
Subject: [PATCH 1/2] Failing test case added.

---
 .../binding-input-group-each-16/_config.js    | 23 +++++++++++++++++++
 .../binding-input-group-each-16/main.svelte   | 17 ++++++++++++++
 2 files changed, 40 insertions(+)
 create mode 100644 packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/_config.js
 create mode 100644 packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/main.svelte

diff --git a/packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/_config.js b/packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/_config.js
new file mode 100644
index 000000000000..54ddd20af17d
--- /dev/null
+++ b/packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/_config.js
@@ -0,0 +1,23 @@
+import { test } from '../../test';
+
+export default test({
+	async test({ assert, target }) {
+		const checkboxes = /** @type {NodeListOf<HTMLInputElement>} */ (
+			target.querySelectorAll('input[type="checkbox"]')
+		);
+
+		assert.isFalse(checkboxes[0].checked);
+		assert.isTrue(checkboxes[1].checked);
+		assert.isFalse(checkboxes[2].checked);
+
+		await checkboxes[1].click();
+
+		const noChecked = target.querySelector('#output')?.innerHTML;
+		assert.equal(noChecked, '');
+
+		await checkboxes[1].click();
+
+		const oneChecked = target.querySelector('#output')?.innerHTML;
+		assert.equal(oneChecked, 'Mint choc chip');
+	}
+});
diff --git a/packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/main.svelte b/packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/main.svelte
new file mode 100644
index 000000000000..56a5465ffe7f
--- /dev/null
+++ b/packages/svelte/tests/runtime-legacy/samples/binding-input-group-each-16/main.svelte
@@ -0,0 +1,17 @@
+<script lang="ts">
+	import { writable } from 'svelte/store';
+	let menu = ['Cookies and cream', 'Mint choc chip', 'Raspberry ripple'];
+	let order = writable({flavours: ['Mint choc chip'], scoops: 1 });
+</script>
+
+<form method="POST">
+	<input type="radio" bind:group={$order.scoops} name="scoops" value={1} /> One scoop
+	<input type="radio" bind:group={$order.scoops} name="scoops" value={2} /> Two scoops
+	<input type="radio" bind:group={$order.scoops} name="scoops" value={3} /> Three scoops
+
+	{#each menu as flavour}
+		<input type="checkbox" bind:group={$order.flavours} name="flavours" value={flavour} /> {flavour}
+	{/each}
+</form>
+
+<div id="output">{$order.flavours.join('+')}</div>
\ No newline at end of file

From e056fa22afb73a3457f29e8672ae6f953667c724 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20S=C3=B6derlund?= <ciscoheat@gmail.com>
Date: Fri, 2 Feb 2024 13:21:28 +0100
Subject: [PATCH 2/2] Fixes binding-input-group-each-16 but introduces a
 failure in binding-input-group-each-12

---
 packages/svelte/src/compiler/phases/2-analyze/index.js | 2 +-
 packages/svelte/src/compiler/phases/types.d.ts         | 2 +-
 packages/svelte/src/compiler/utils/ast.js              | 7 ++-----
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/packages/svelte/src/compiler/phases/2-analyze/index.js b/packages/svelte/src/compiler/phases/2-analyze/index.js
index 6f8bfd2064d9..e06474b34dcc 100644
--- a/packages/svelte/src/compiler/phases/2-analyze/index.js
+++ b/packages/svelte/src/compiler/phases/2-analyze/index.js
@@ -1036,7 +1036,7 @@ const common_visitors = {
 		// If the same identifiers in the same order are used in another bind:group, they will be in the same group.
 		// (there's an edge case where `bind:group={a[i]}` will be in a different group than `bind:group={a[j]}` even when i == j,
 		//  but this is a limitation of the current static analysis we do; it also never worked in Svelte 4)
-		const bindings = expression_ids.map((id) => context.state.scope.get(id.name));
+		const bindings = expression_ids.map((id) => context.state.scope.get(id.name) ?? id);
 		let group_name;
 		outer: for (const [b, group] of context.state.analysis.binding_groups) {
 			if (b.length !== bindings.length) continue;
diff --git a/packages/svelte/src/compiler/phases/types.d.ts b/packages/svelte/src/compiler/phases/types.d.ts
index ba1c14788910..cb0039b18bd3 100644
--- a/packages/svelte/src/compiler/phases/types.d.ts
+++ b/packages/svelte/src/compiler/phases/types.d.ts
@@ -68,7 +68,7 @@ export interface ComponentAnalysis extends Analysis {
 	inject_styles: boolean;
 	reactive_statements: Map<LabeledStatement, ReactiveStatement>;
 	/** Identifiers that make up the `bind:group` expression -> internal group binding name */
-	binding_groups: Map<Array<Binding | null>, Identifier>;
+	binding_groups: Map<Array<Binding | Identifier | null>, Identifier>;
 	slot_names: Set<string>;
 }
 
diff --git a/packages/svelte/src/compiler/utils/ast.js b/packages/svelte/src/compiler/utils/ast.js
index 9f16679bc730..ae28ca077eed 100644
--- a/packages/svelte/src/compiler/utils/ast.js
+++ b/packages/svelte/src/compiler/utils/ast.js
@@ -108,11 +108,8 @@ export function extract_all_identifiers_from_expression(expr) {
 		expr,
 		{},
 		{
-			Identifier(node, { path }) {
-				const parent = path.at(-1);
-				if (parent?.type !== 'MemberExpression' || parent.property !== node || parent.computed) {
-					nodes.push(node);
-				}
+			Identifier(node) {
+				nodes.push(node);
 			}
 		}
 	);