From 6df7989206625afa3106570ebc53dce64a2ee77d Mon Sep 17 00:00:00 2001 From: Van Nguyen Date: Fri, 21 Aug 2020 16:25:50 +1000 Subject: [PATCH] perf: convert empty text nodes to comments --- src/runtime/internal/dom.ts | 2 +- test/runtime/samples/raw-mustache-inside-head/_config.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runtime/internal/dom.ts b/src/runtime/internal/dom.ts index 7087336a6b29..535248c511cd 100644 --- a/src/runtime/internal/dom.ts +++ b/src/runtime/internal/dom.ts @@ -54,7 +54,7 @@ export function space() { } export function empty() { - return text(''); + return document.createComment(''); } export function listen(node: EventTarget, event: string, handler: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions | EventListenerOptions) { diff --git a/test/runtime/samples/raw-mustache-inside-head/_config.js b/test/runtime/samples/raw-mustache-inside-head/_config.js index 7923fc72380e..775a6510e86d 100644 --- a/test/runtime/samples/raw-mustache-inside-head/_config.js +++ b/test/runtime/samples/raw-mustache-inside-head/_config.js @@ -3,14 +3,14 @@ export default { const btn = target.querySelector("button"); const clickEvent = new window.MouseEvent("click"); - assert.equal(window.document.head.innerHTML.includes(''), true); + assert.equal(window.document.head.innerHTML.includes(''), true); await btn.dispatchEvent(clickEvent); - assert.equal(window.document.head.innerHTML.includes(''), true); + assert.equal(window.document.head.innerHTML.includes(''), true); await btn.dispatchEvent(clickEvent); - assert.equal(window.document.head.innerHTML.includes(''), true); + assert.equal(window.document.head.innerHTML.includes(''), true); } };