Gitea backend issue when fetching repository tree

[joh-ku]

Using Gitea backend I'm experiencing an issue when fetching the repository tree at https://gitea.com/api/v1/repos/{owner}/{repo}/git/trees/{sha}.

Sveltia fetches data from the tree split into chunks with 1000 items each. Once the full tree and all chunks are fetched, there is another call to this endpoint where Gitea returns tree: null.

The response body looks like this:

{
"sha":"{sha}",
"url":"https://gitea.com/api/v1/repos/{owner}/{repo}/git/trees/{sha}",
"tree":null,
"truncated":false,
"page":14,
"total_count":12697
}

In this case, when tree is null like above, Sveltia aborts with "There was an error while loading site data. Unexpected error". In the console I see:

can't access property Symbol.iterator, a.tree is null undefined

[joh-ku]

I can work around this issue by setting Gitea config DEFAULT_GIT_TREES_PER_PAGE = {number}, where {number} ≥ total_count.
It seems there is a not null check missing when iterating data chunks.

[kyoshino]

Good catch!

The last page returns "truncated":true even when there are no more items? It sounds like a bug in Gitea.

Anyway I’ll fix our implementation now.

[kyoshino]

Fixed in v0.91.3.

[joh-ku]

Thank you for the quick fix!
I think you're right — the final API call, which isn't truncated, should indeed return truncated: false.
I'll go ahead and open an upstream issue. Let's see how they respond to this.

[joh-ku]

//confirmed fixed in v0.91.3.