Skip to content

Consider moving react to peerDependencies in package.json #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HQidea opened this issue Feb 11, 2018 · 2 comments
Closed

Consider moving react to peerDependencies in package.json #1670

HQidea opened this issue Feb 11, 2018 · 2 comments
Assignees

Comments

@HQidea
Copy link

HQidea commented Feb 11, 2018

If we're still using react lower than 15.6.2, then we will occur an error in broswer:

image

It seems there are 2 different versions of react loaded.

"react": "^15.6.2",
"react-addons-css-transition-group": "^15.4.2",
"react-dd-menu": "^2.0.0",
"react-dom": "^15.6.2",

change to

// package.json

"peerDependencies": {
  "react": ">=15.0.0",
  "react-dom": ">=15.0.0"
}
@shockey
Copy link
Contributor

shockey commented Mar 7, 2018

Duplicate of swagger-api/swagger-ui#3934; closing

@shockey shockey closed this as completed Mar 7, 2018
@shockey
Copy link
Contributor

shockey commented Mar 7, 2018

(not that you should've known to check there, but the discussion there is applicable to both Swagger-UI and Swagger-Editor!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants